[Asterisk-code-review] media: Add experimental support for RTCP feedback. (asterisk[14])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/4521 )

Change subject: media: Add experimental support for RTCP feedback.
......................................................................


Patch Set 2:

(2 comments)

https://gerrit.asterisk.org/#/c/4521/2/codecs/codec_speex.c
File codecs/codec_speex.c:

PS2, Line 372: 			ast_verb(3, "Fraction lost changed: %d --> %d percent loss\n", fraction_lost, percent);
             : 			/* Handle change */
             : 			speex_encoder_ctl(tmp->speex, SPEEX_GET_BITRATE, &bitrate);
             : 			ast_verb(3, "Current bitrate: %d\n", bitrate);
             : 			ast_verb(3, "Current quality: %d/%d\n", tmp->quality, tmp->default_quality);
> Yes, I only added them to be sure I was doing the right thing. Is there any
ast_debug can be used to output debug messages and are enabled using "core set debug <level>" with debug going to a file or console in logger.conf


https://gerrit.asterisk.org/#/c/4521/2/res/res_rtp_asterisk.c
File res/res_rtp_asterisk.c:

Line 4334: 				report_block = rtp->f.data.ptr + rtp->f.datalen + sizeof(struct ast_rtp_rtcp_report_block *);
> I think it was because from my tests sizeof(struct ast_rtp_rtcp_report) wou
Ah, yes, that would make sense.


-- 
To view, visit https://gerrit.asterisk.org/4521
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifd6aa77fb4a7ff546c6025900fc2baf332c31857
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: 14
Gerrit-Owner: Lorenzo Miniero <lminiero at gmail.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Lorenzo Miniero <lminiero at gmail.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes