[Asterisk-code-review] app mp3: Use correct buffer size (asterisk[13])

Mark Michelson asteriskteam at digium.com
Wed Aug 31 16:42:09 CDT 2016


Mark Michelson has posted comments on this change.

Change subject: app_mp3: Use correct buffer size
......................................................................


Patch Set 2: Code-Review-1

>From Jenkins:
2016-08-31 13:33:13 app_mp3.c: In function 'mp3play':
2016-08-31 13:33:13 app_mp3.c:99: error: 'sampling_rate' undeclared (first use in this function)
2016-08-31 13:33:13 app_mp3.c:99: error: (Each undeclared identifier is reported only once
2016-08-31 13:33:13 app_mp3.c:99: error: for each function it appears in.)

It looks like your cherry pick missed the declaration and initialization of 'sampling_rate'

-- 
To view, visit https://gerrit.asterisk.org/3740
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id1ee274733cd804a0edecf7450329b72f1235af0
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Michael Kuron <m.kuron at gmx.de>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-HasComments: No



More information about the asterisk-code-review mailing list