[Asterisk-code-review] rtp engine: Allow more than 32 dynamic payload types. (asterisk[13])

Joshua Colp asteriskteam at digium.com
Tue Aug 30 07:40:32 CDT 2016


Joshua Colp has posted comments on this change.

Change subject: rtp_engine: Allow more than 32 dynamic payload types.
......................................................................


Patch Set 1: Code-Review-1

I think if we're going to accept this we're going to need to put it behind a config option like Kevin mentions and default it to no in 13 and 14 so the behavior is unchanged. If someone using allow=all upgraded, had enough codecs loaded to trigger it, had it break their call then that is unacceptable. It would also need to be documented in the CHANGES file. For master we can turn it on by default and see how it goes.

-- 
To view, visit https://gerrit.asterisk.org/3681
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7bc96ab764bc30098a178b841cbf7146f9d64964
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-HasComments: No



More information about the asterisk-code-review mailing list