[Asterisk-code-review] app mp3: use correct buffer size for streams (asterisk[master])

[Kevin Harwell]

Kevin Harwell has posted comments on this change.

Change subject: app_mp3: use correct buffer size for streams
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

According to the usage docs found at http://linux.die.net/man/1/mpg123 it doesn't make much sense to set the buffer size below 300. Even set at 300 I am not sure that would be the correct setting for everyone.

What about adding an optional parameter that can be passed in via the dialplan? That way people can set it to anything they want.

https://gerrit.asterisk.org/#/c/3738/1//COMMIT_MSG
Commit Message:

Line 12: 
The description needs the issue number, and if it makes sense, followed by a #close. See "Issue referencing" at the following for more info:

tps://wiki.asterisk.org/wiki/display/AST/Commit+Messages


-- 
To view, visit https://gerrit.asterisk.org/3738
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id1ee274733cd804a0edecf7450329b72f1235af0
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Michael Kuron <m.kuron at gmx.de>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-HasComments: Yes