[Asterisk-code-review] channel: Hang-up crashed Asterisk while freeing private data. (asterisk[11])

[Richard Mudgett]

Richard Mudgett has posted comments on this change.

Change subject: channel: Hang-up crashed Asterisk while freeing private data.
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/3731/1/main/channel.c
File main/channel.c:

PS1, Line 2352: 		ast_log_callid(LOG_ERROR, callid, "Channel '%s' may not have been hung up" \
              : 			" properly; leaking memory. Please report via http://issues.asterisk.org." \
              : 			" If feasible, please include" \
              : 			" http://wiki.asterisk.org/wiki/display/AST/Getting+a+Backtrace" \
              : 			" via an interactive session in the GNU Debugger (gdb).\n",
              : 			ast_channel_name(chan));
> Done (partially)
Asserts are evaluated only if Asterisk is compiled in developer mode.  With asserts enabled then when you get an assertion failure a message is logged along with a stack trace of the current thread output to the log file.  The generated stack trace is helped immensely by also enabling BETTER_BACKTRACES in menuselect.  The message logged is something like this:
"FRACK! Assertion failure ...."
"stack trace of up to 20 function calls"

If you also enable DO_CRASH in menuselect then an assertion will abort with the optional core dump.

I already suggested the shorter message!  The "BUG!" prefix of the suggested message should be a big clue to people that they have uncovered a programming error and should be reported.  The extra wording you added doesn't say anything that isn't always asked for by the issue guidelines.  The fact that people don't collect the asked for information even when given links to more detailed instructions on how to do so cannot be helped.


-- 
To view, visit https://gerrit.asterisk.org/3731
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id085417d7e0a5c61382582e7d250b56ab3c00a1b
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: 11
Gerrit-Owner: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes