[Asterisk-code-review] chan sip: Allow Preferred sRTP. (asterisk[master])

Joshua Colp asteriskteam at digium.com
Fri Aug 26 09:40:18 CDT 2016


Joshua Colp has posted comments on this change.

Change subject: chan_sip: Allow Preferred sRTP.
......................................................................


Patch Set 1: -Code-Review

Indeed, it was for consistency I was mentioning it and real world use. I can confirm that the way PJSIP does it has been tested against different implementations and works. It's not guaranteed to work because of what you've said, and the fallback is doing exactly as you've mentioned. If what you've mentioned is documented somewhere as how to do it when used with chan_sip, then I'm fine with it.

-- 
To view, visit https://gerrit.asterisk.org/3234
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I42cb779df3a9c7b3dd03a629fb3a296aa4ceb0fd
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-HasComments: No



More information about the asterisk-code-review mailing list