[Asterisk-code-review] app macro: Consider '~~s~~' as a macro start extension. (asterisk[master])

Joshua Colp asteriskteam at digium.com
Thu Aug 25 07:27:51 CDT 2016


Joshua Colp has posted comments on this change.

Change subject: app_macro: Consider '~~s~~' as a macro start extension.
......................................................................


Patch Set 3: Code-Review+1

I've gone ahead and taken care of the formatting problems and commit message. As for looking at the actual code - I had no comments on that.

As for the difficulty in things: I do apologize and hope you understand that we are here if you have problems submitting patches in the future or need help with something. I've also gone ahead and added a note to the wiki page so that others do not have the same problem you encountered and are aware of the problem with running indent on an existing module.

-- 
To view, visit https://gerrit.asterisk.org/3578
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I939aa2a694148cc1054dd75ec0c47c47f47c90fb
Gerrit-PatchSet: 3
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: chris de rock <chris at derock.de>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: chris de rock <chris at derock.de>
Gerrit-HasComments: No



More information about the asterisk-code-review mailing list