[Asterisk-code-review] issue ASTERISK-26282 (asterisk[master])

[Joshua Colp]

Joshua Colp has posted comments on this change.

Change subject: issue ASTERISK-26282
......................................................................


Patch Set 1:

If you'd like help we can certainly split out your fix for you, you just need to ask if you were uncomfortable or didn't want to spend time doing so.

On the policy of coding guidelines newer code that goes in should adhere to the guidelines when possible. In your case app_macro is a VERY old module which predates a lot of stuff.

-- 
To view, visit https://gerrit.asterisk.org/3578
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I939aa2a694148cc1054dd75ec0c47c47f47c90fb
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: chris de rock <chris at derock.de>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: chris de rock <chris at derock.de>
Gerrit-HasComments: No