[Asterisk-code-review] res pjsip: Re-use IP version of signaling (SIP) for media (R... (asterisk[13])

[Joshua Colp]

Joshua Colp has posted comments on this change.

Change subject: res_pjsip: Re-use IP version of signaling (SIP) for media (RTP).
......................................................................


Patch Set 1:

It's a scenario that is actually tested at SIPit sometimes. The IP version of the SIP signaling and the IP versioning of SDP/RTP have no relation, except any relation you give it in your software. Using ICE you could actually have candidates for both (which we don't currently support - but it's possible). I don't think there's an RFC specifically about it, as they are separate to begin with.

For released branches the rtp_ipv6 option should have an additional value 'automatic' that becomes the new default. This ensures that anyone using the option already does not have any problems with the upgrade. It should also be documented in CHANGES.

As for IPv6 support in general it was tested during SIPit by creating two transports bound explicitly to the host addresses and having endpoints configured with RTP over IPv6. This worked during testing against a few other SIP devices.

As for your comment about investigating. I did and I did report it to Teluu. What is not supported (and I don't believe still is) is a single transport using both IPv4 and IPv6 as their parser does not support mapped addresses for IPv4. Separate transports if bound explicitly have always worked, you've just made it nicer by having it be wildcard as well. If mapped addresses have also been fixed, then all the better.

So - IPv6 support did work, just not as nice as some people might have wanted.

As for your comment about it being a bug if there is any way possible when making a behavior change to ensure that anyone who may be using the functionality previously is unaffected but new people see the new behavior I *always* opt for doing that. Why? Because disturbing any configuration in a released branch should NOT be taken lightheartedly. We should try to minimize any impact we make and ensure upgrades are smooth.

-- 
To view, visit https://gerrit.asterisk.org/3663
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I01a85a8c6723fcc12e86139f80e090e2078d04bb
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-HasComments: No