[Asterisk-code-review] apps: Add a test for the BridgeAdd application (testsuite[master])

[Richard Mudgett]

Richard Mudgett has posted comments on this change.

Change subject: apps:  Add a test for the BridgeAdd application
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/3569/2/tests/apps/bridge/bridge_add/test-config.yaml
File tests/apps/bridge/bridge_add/test-config.yaml:

PS2, Line 43:         ami-events:
            :             conditions:
            :                 match:
            :                     Event: 'BridgeEnter'
            :                     BridgeTechnology: 'simple_bridge'
            :                     Channel: 'Local/bob at default-00000001;1'
            :             count: 1
You need to wait for both alice channels to enter a bridge to be sure that there isn't a race condition when finding an alice channel bridge to join when giving BridgeAdd a partial local channel name.

Either that or look for the Local/alice-00000000;1 channel to join here and give BridgeAdd the full channel name since we are dealing with local channels.


-- 
To view, visit https://gerrit.asterisk.org/3569
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib4d51eb1495d13ecf840a055bfbe918832381f1b
Gerrit-PatchSet: 2
Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes