[Asterisk-code-review] ConfBridge: Rework announcer channel methodology (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change.

Change subject: ConfBridge: Rework announcer channel methodology
......................................................................


Patch Set 2: Code-Review-1

(3 comments)

https://gerrit.asterisk.org/#/c/3504/2//COMMIT_MSG
Commit Message:

Line 7: ConfBridge: Rework announcer channel methodology
Ooops.  Looks like you merged the commit messages.


https://gerrit.asterisk.org/#/c/3504/2/apps/app_confbridge.c
File apps/app_confbridge.c:

Line 1805: 	/* Wait for the initiator to get back in the bridge or be hung up*/
This isn't going to work.  For the join sound it will work  because you aren't in the bridge yet unless the channel actually fails to join the bridge for some reason.  For the mute/unmute sound you are in a DTMF hook so you are already in the bridge.  For a hangup that would be problematic because someone leaving the confbridge doesn't necessarily get hung up.  They could be kicked out and continue in the dialplan.

Maybe use a datastore on the channel to wake up the announcer at strategic locations if you are in the bridge.  For the DTMF hook you need to manually trigger when the hook is complete.

The following hooks may be useful.
ast_bridge_join_hook()
ast_bridge_leave_hook()
ast_bridge_hangup_hook()
ast_bridge_move_hook()


Line 2308: 		ast_stream_and_wait(user->chan, sound_to_play, "");
Should reserect the comment here:
The host needs to hear it seperately, as they don't get the audio from play_sound_helper.


-- 
To view, visit https://gerrit.asterisk.org/3504
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie486bb3de1646d50894489030326a423e594ab0a
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes