[Asterisk-code-review] astconfigparser: Really handle case where line is simply a c... (asterisk[14])

[Joshua Colp]

Joshua Colp has submitted this change and it was merged.

Change subject: astconfigparser: Really handle case where line is simply a comment.
......................................................................


astconfigparser: Really handle case where line is simply a comment.

The regular expression would match causing the code that handled
the line if it was merely a comment to never get executed.

Change-Id: I3e4022481037ebcba9905587fe8c764b4ce21819
---
M contrib/scripts/sip_to_pjsip/astconfigparser.py
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Kevin Harwell: Looks good to me, but someone else must approve
  Anonymous Coward #1000019: Verified
  Joshua Colp: Looks good to me, approved



diff --git a/contrib/scripts/sip_to_pjsip/astconfigparser.py b/contrib/scripts/sip_to_pjsip/astconfigparser.py
index a6d88c7..dc79e80 100644
--- a/contrib/scripts/sip_to_pjsip/astconfigparser.py
+++ b/contrib/scripts/sip_to_pjsip/astconfigparser.py
@@ -203,7 +203,7 @@
     if match:
          # the end of where the real string is is where the comment starts
          line = line[0:(match.end()-1)]
-    elif line.startswith(";"):
+    if line.startswith(";"):
          # if the line is actually a comment just ignore it all
          line = ""
 

-- 
To view, visit https://gerrit.asterisk.org/3407
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I3e4022481037ebcba9905587fe8c764b4ce21819
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 14
Gerrit-Owner: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>