[Asterisk-code-review] res pjsip outbound publish: Add multi-user support per confi... (asterisk[master])

[Joshua Colp]

Joshua Colp has posted comments on this change.

Change subject: res_pjsip_outbound_publish: Add multi-user support per configuration
......................................................................


Patch Set 1:

(3 comments)

https://gerrit.asterisk.org/#/c/2709/1/include/asterisk/res_pjsip_outbound_publish.h
File include/asterisk/res_pjsip_outbound_publish.h:

PS1, Line 174: int ast_sip_publish_user_send(const char *user, const struct ast_sip_body *body);
             : 
             : /*!
             :  * \brief Remove the given user and stop outbound publishing for it
             :  *
             :  * \param user The user to remove
             :  */
             : void ast_sip_publish_user_remove(const char *user);
> What do you mean by "Users shouldn't be global"? For this function I could 
Correct - a client will be passed in, and when an implementation is told to start it can hold a reference to the client so it can use that to send the publish.


https://gerrit.asterisk.org/#/c/2709/1/res/res_pjsip_outbound_publish.c
File res/res_pjsip_outbound_publish.c:

Line 200: static struct ao2_container *multi_publishes;
> There is only one publish [configuration] type per publish client. However 
Is the start callback still invoked on the implementation so it knows to start things? If not then it would have no idea of things.


Line 824: 	ao2_callback_data(multi_publishes, OBJ_NODATA,
> I thought the ao2_callback code would mutex lock the multi_publishes contai
You would be right, disregard


-- 
To view, visit https://gerrit.asterisk.org/2709
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib88dde024cc83c916424645d4f5bb84a0fa936cc
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-HasComments: Yes