[Asterisk-code-review] Add a regcontext option for confbridge bridge profiles. (asterisk[11])

[Joshua Colp]

Joshua Colp has posted comments on this change.

Change subject: Add a regcontext option for confbridge bridge profiles.
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

Purely from a coding perspective this is... fine. To get it in you'd need to do it against master, and also update the CHANGES file.

Not really sure how many other people would use it but it's minor enough.

https://gerrit.asterisk.org/#/c/2708/1//COMMIT_MSG
Commit Message:

Line 7: Add a regcontext option for confbridge bridge profiles.
If you want to see this included in the future then the commit message template should be followed.


https://gerrit.asterisk.org/#/c/2708/1/apps/confbridge/include/confbridge.h
File apps/confbridge/include/confbridge.h:

Line 203: 	char regcontext[64];
This should be using AST_MAX_CONTEXT which defines the maximum size of a context.


-- 
To view, visit https://gerrit.asterisk.org/2708
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icacf94d9f2b5dfd31ef36f6cb702392619a7902f
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 11
Gerrit-Owner: Jaco Kroon <jaco at uls.co.za>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-HasComments: Yes