[Asterisk-code-review] config: Fix ast config text file save writability check for... (asterisk[11])

[Richard Mudgett]

Richard Mudgett has posted comments on this change.

Change subject: config:  Fix ast_config_text_file_save writability check for missing files
......................................................................


Patch Set 3: Code-Review-1

(3 comments)

https://gerrit.asterisk.org/#/c/2693/3/main/config.c
File main/config.c:

Line 2138: 		if (!dn || access(dn, R_OK | W_OK)) {
ast_strdupa never fails so no need to check dn for NULL


Line 2140: 			ast_free(dn);
You no longer need to ast_free() since you now use ast_strdupa()


Line 2143: 		ast_free(dn);
idem


-- 
To view, visit https://gerrit.asterisk.org/2693
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4dbe58c277a47b674679e49daed5fc6de349f80
Gerrit-PatchSet: 3
Gerrit-Project: asterisk
Gerrit-Branch: 11
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jonathan R. Rose <jonathan.rose at motorolasolutions.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes