[Asterisk-code-review] app queue: queue members can receive multiple calls (asterisk[certified/13.1])

Kevin Harwell asteriskteam at digium.com
Mon Apr 25 12:39:04 CDT 2016


Hello Mark Michelson, Richard Mudgett, Anonymous Coward #1000019, George Joseph,

I'd like you to reexamine a change.  Please visit

    https://gerrit.asterisk.org/2676

to look at the new patch set (#2).

Change subject: app_queue: queue members can receive multiple calls
......................................................................

app_queue: queue members can receive multiple calls

It was possible for a queue member that is a member of at least 2 or more
queues to receive mulitiple calls at the same time. This happened because
of a race between when a member was being rung and when the device state
notified the other queue(s) member object of the state change.

This patch makes it so when a queue member is being rung it gets added to
a global pool of queue members. If that same member is tried again, e.g.
from another queue, and it is found to already exist in the pending member
container then it will not ring that member.

ASTERISK-16115 #close

Change-Id: I546dd474776d158c2b6be44205353dee5bac7e48
---
M apps/app_queue.c
1 file changed, 101 insertions(+), 44 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/76/2676/2
-- 
To view, visit https://gerrit.asterisk.org/2676
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I546dd474776d158c2b6be44205353dee5bac7e48
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: certified/13.1
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>



More information about the asterisk-code-review mailing list