[Asterisk-code-review] res pjsip: disable multi domain to improve realtime performace (asterisk[13])

[George Joseph]

George Joseph has posted comments on this change.

Change subject: res_pjsip: disable multi domain to improve realtime performace
......................................................................


Patch Set 1: Code-Review-1

(9 comments)

Just cosmetic issues so far.
I can actually test this later.

https://gerrit.asterisk.org/#/c/2623/1/configs/samples/pjsip.conf.sample
File configs/samples/pjsip.conf.sample:

PS1, Line 904: disable
s/disable/disabled/


PS1, Line 904: reduce
s/redice/reducing/


https://gerrit.asterisk.org/#/c/2623/1/contrib/ast-db-manage/config/versions/8d478ab86e29_pjsip_add_diable_multi_domain.py
File contrib/ast-db-manage/config/versions/8d478ab86e29_pjsip_add_diable_multi_domain.py:

PS1, Line 1: pjsip_add_diable_multi_domain
s/diable/disable/

Also in the file name.


PS1, Line 27: diable_multi_domain
s/diable/disable/


PS1, Line 31: diable_multi_domain
s/diable/disable/


https://gerrit.asterisk.org/#/c/2623/1/include/asterisk/res_pjsip.h
File include/asterisk/res_pjsip.h:

Line 2263:  *
Add a "\since 13.9.0" tag.


https://gerrit.asterisk.org/#/c/2623/1/res/res_pjsip.c
File res/res_pjsip.c:

PS1, Line 1297: disable
s/disable/disabled/


PS1, Line 1297: reduce
s/reduce/reducing/


https://gerrit.asterisk.org/#/c/2623/1/res/res_pjsip/config_global.c
File res/res_pjsip/config_global.c:

Line 68:         /*! Nonzero to disable multi domain support */
Check indentation.  Looks like spaces instead of tabs.


-- 
To view, visit https://gerrit.asterisk.org/2623
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2e7160f3aae68475d52742107949a799aa2c7dc7
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: George Joseph <george.joseph at fairview5.com>
Gerrit-HasComments: Yes