[Asterisk-code-review] res pjsip: Add serialized scheduler (res pjsip/pjsip schedu... (asterisk[13])

[Mark Michelson]

Mark Michelson has posted comments on this change.

Change subject: res_pjsip:  Add serialized scheduler (res_pjsip/pjsip_scheduler.c)
......................................................................


Patch Set 5: Code-Review+1

(1 comment)

https://gerrit.asterisk.org/#/c/2443/5/tests/test_res_pjsip_scheduler.c
File tests/test_res_pjsip_scheduler.c:

PS5, Line 147: 	ast_test_validate(test, (duration > ((test_data1->interval + test_data1->sleep) * 0.9))
             : 		&& (duration < ((test_data1->interval + test_data1->sleep) * 1.1)));
It may be worthwhile to add a similar check to ensure that the task's start time is approximately (test_data->start_time - [time when task was scheduled])


-- 
To view, visit https://gerrit.asterisk.org/2443
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7af6ad2b2d896ea68e478aa1ae201d6dd016ba1c
Gerrit-PatchSet: 5
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: George Joseph <george.joseph at fairview5.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: George Joseph <george.joseph at fairview5.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes