[Asterisk-code-review] translate: Re-enables native Packet-Loss Concealment (PLC) f... (asterisk[master])

[Alexander Traud]

Alexander Traud has posted comments on this change.

Change subject: translate: Re-enables native Packet-Loss Concealment (PLC) for iLBC and Speex.
......................................................................


Patch Set 9:

Thank you for the valuable input. I found a solution which does not require to change any internally created frames, still detecting lost/last packets reliably.

This creates one corner case: If the last received packet had seqno 0 and exactly 0xffff frames are lost, we do not do PLC. However, in such a terrible rare case, a lot of other issues would happen, like with sRTP, the internal counter would be wrong = no audio anymore.

I increased the log output a bit because 50 is actually quite common. Therefore, I decreased from Warning to Notice. main/cannel.c:__ast_queue_frame gives a Warning already in that case. Furthermore, with 96 both give a notice/warning at the same time.

res/res_rtp_asterisk.c:ast_rtp_read changes behavior after 100 lost frames. Perhaps, that value/code must be harmonized, as well. Hope, you like it!

-- 
To view, visit https://gerrit.asterisk.org/1820
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibfcf0670e094e9718d82fd9920f1fb2dae122006
Gerrit-PatchSet: 9
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Matthew Fredrickson <creslin at digium.com>
Gerrit-HasComments: No