[Asterisk-code-review] lock: Add named lock capability (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change.

Change subject: lock:  Add named lock capability
......................................................................


Patch Set 8:

(2 comments)

https://gerrit.asterisk.org/#/c/2521/8/include/asterisk/named_locks.h
File include/asterisk/named_locks.h:

Line 56:  * \internal
The enum is not internal in the public header.


https://gerrit.asterisk.org/#/c/2521/8/main/named_locks.c
File main/named_locks.c:

Line 96: 	return ast_register_atexit(named_locks_shutdown);
This should be ast_register_cleanup().
ast_register_atexit is always run on shutdown.  cleanup is only run on graceful or when-convenient shutdowns when things are more likely to be done using things.

Nobody else returns the ast_register_cleanup() return value.  It's just ignored.


-- 
To view, visit https://gerrit.asterisk.org/2521
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If258c0b7f92b02d07243ce70e535821a1ea7fb45
Gerrit-PatchSet: 8
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: George Joseph <george.joseph at fairview5.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes