[Asterisk-code-review] res pjsip: Add ability to identify by Authorization username (asterisk[13])

[Joshua Colp]

Joshua Colp has posted comments on this change.

Change subject: res_pjsip:  Add ability to identify by Authorization username
......................................................................


Patch Set 13:

(3 comments)

https://gerrit.asterisk.org/#/c/2367/13/res/res_pjsip/pjsip_distributor.c
File res/res_pjsip/pjsip_distributor.c:

Line 624: 	ao2_ref(unidentified_requests, +1);
Why the +1? Are you trying to stop a problem at shutdown? This just narrows the window.


https://gerrit.asterisk.org/#/c/2367/13/res/res_pjsip_endpoint_identifier_user.c
File res/res_pjsip_endpoint_identifier_user.c:

Line 49: 	header = pjsip_msg_find_hdr(rdata->msg_info.msg, PJSIP_H_AUTHORIZATION, NULL);
There can actually be multiple Authorization headers, not just one.


https://gerrit.asterisk.org/#/c/2367/13/res/res_pjsip_registrar.c
File res/res_pjsip_registrar.c:

Line 725: 			header = pjsip_msg_find_hdr(rdata->msg_info.msg, PJSIP_H_AUTHORIZATION, NULL);
Ditto.


-- 
To view, visit https://gerrit.asterisk.org/2367
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I30ba62d208e6f63439600916fcd1c08a365ed69d
Gerrit-PatchSet: 13
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: George Joseph <george.joseph at fairview5.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: George Joseph <george.joseph at fairview5.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-HasComments: Yes