[Asterisk-code-review] res/res rtp asterisk: Ensure ICE support is enabled before l... (asterisk[master])

Elazar Broad asteriskteam at digium.com
Thu Sep 24 17:43:05 CDT 2015


Elazar Broad has uploaded a new change for review.

  https://gerrit.asterisk.org/1310

Change subject: res/res_rtp_asterisk: Ensure ICE support is enabled before logging a warning.
......................................................................

res/res_rtp_asterisk: Ensure ICE support is enabled before logging a warning.

Commit 8e5ed27 added additional debug logging logic for ICE.
One of these statements will issue a warning regardless if
ICE is enabled or not in rtp.conf. This commit resolves that.

Change-Id: I04b2bf5b29f0a0e21c9db33cbcea89e11dfd6f6c
---
M res/res_rtp_asterisk.c
1 file changed, 2 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/10/1310/1

diff --git a/res/res_rtp_asterisk.c b/res/res_rtp_asterisk.c
index a51e07c..564d861 100644
--- a/res/res_rtp_asterisk.c
+++ b/res/res_rtp_asterisk.c
@@ -799,7 +799,8 @@
 		role == AST_RTP_ICE_ROLE_CONTROLLED ? "CONTROLLED" : "CONTROLLING", instance);
 
 	if (!rtp->ice) {
-		ast_log(LOG_WARNING, "Set role failed; no ice instance (%p)\n", instance);
+		if (icesupport)
+			ast_log(LOG_WARNING, "Set role failed; no ice instance (%p)\n", instance);
 		return;
 	}
 

-- 
To view, visit https://gerrit.asterisk.org/1310
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I04b2bf5b29f0a0e21c9db33cbcea89e11dfd6f6c
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Elazar Broad <elazar at thebroadfamily.com>



More information about the asterisk-code-review mailing list