[Asterisk-code-review] res pjsip distributor: Get a reference to dialog serializer. (asterisk[13])

[Mark Michelson]

Mark Michelson has posted comments on this change.

Change subject: res_pjsip_distributor: Get a reference to dialog serializer.
......................................................................


Patch Set 1:

> Should the serializer be removed from the dialog when sending the
 > final NOTIFY?
 > 
 > Un-related: In that scenario if the serializer does live what will
 > the end result of the subscription and the SUBSCRIBE handling be?

I mentioned already what the result of the SUBSCRIBE handling would be. The request would either be blocked by the pjsip_evsub module or it will be ignored by us since we already have removed the pjsip_evsub's reference to the subscription tree. We'd try to grab the subscription tree off the pjsip_evsub, we'd get a NULL pointer, and just return immediately.

Removing the serializer from the dialog when sending the final NOTIFY would more closely mimic what the session code does. It may be the proper answer, but like I said, I can't necessarily prove that the session code is flawless. It's a case where that may fix the problem for subscriptions but sessions still have some edge case I haven't found yet.

-- 
To view, visit https://gerrit.asterisk.org/1284
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I14563093f8320f79063b65792461f18f06c07a77
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: No