[Asterisk-code-review] app queue: Test blind and attended transfers with queues (testsuite[master])

[Scott Griepentrog]

Scott Griepentrog has posted comments on this change.

Change subject: app_queue: Test blind and attended transfers with queues
......................................................................


Patch Set 1: Code-Review-1

(3 comments)

https://gerrit.asterisk.org/#/c/1274/1/tests/apps/queues/transfer/caller_attended/test-config.yaml
File tests/apps/queues/transfer/caller_attended/test-config.yaml:

Line 100:             conditions:
        :                 match:
        :                     Event: 'VarSet'
        :                     Variable: BRIDGEPEER
        :                     Channel: 'PJSIP/alice-.*'
        :                     Value: 'PJSIP/charlie-.*'
        :             count: '3'
        :             conditions:
        :                 match:
        :                     Event: 'VarSet'
        :                     Variable: BRIDGEPEER
        :                     Channel: 'PJSIP/charlie-.*'
        :                     Value: 'PJSIP/alice-.*'
        :             count: '3'
The values duplicated here (I believe) result in only one set of conditions/count in the ami-events dict, which means that you're not actually checking for both sets of bridgepeer varset events.


Line 122:             conditions:
        :                 match:
        :                     Event: 'AttendedTransfer'
        :                     OrigTransfererChannel: 'PJSIP/alice-.*'
        :                     SecondTransfererChannel: 'PJSIP/alice-.*'
        :                     TransfereeChannel: 'PJSIP/bob-.*'
        :                     TransferTargetChannel: 'PJSIP/charlie-.*'
        :                     Result: 'Success'
        :             count: 1
        :             conditions:
        :                 match:
        :                     Event: 'AgentComplete'
        :                     Channel: 'PJSIP/alice-.*'
        :                     MemberName: 'PJSIP/bob'
        :                     Reason: 'transfer'
        :             count: 1
Duplicated


https://gerrit.asterisk.org/#/c/1274/1/tests/apps/queues/transfer/caller_blind/test-config.yaml
File tests/apps/queues/transfer/caller_blind/test-config.yaml:

Line 100:             conditions:
        :                 match:
        :                     Event: 'BlindTransfer'
        :                     TransfererChannel: 'PJSIP/alice-.*'
        :                     TransfereeChannel: 'PJSIP/bob-.*'
        :                     Extension: '102'
        :                     Result: 'Success'
        :             count: 1
        :             conditions:
        :                 match:
        :                     Event: 'AgentComplete'
        :                     Channel: 'PJSIP/alice-.*'
        :                     MemberName: 'PJSIP/bob'
        :                     Reason: 'transfer'
        :             count: 1
duplicated values


-- 
To view, visit https://gerrit.asterisk.org/1274
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I359ce622f4be04c1af7e10a41a39425b6674ea03
Gerrit-PatchSet: 1
Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Scott Griepentrog <sgriepentrog at digium.com>
Gerrit-HasComments: Yes