[Asterisk-code-review] res pjsip pubsub.c: Fix one byte buffer overrun error. (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change.

Change subject: res_pjsip_pubsub.c: Fix one byte buffer overrun error.
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/#/c/1241/1/res/res_pjsip_pubsub.c
File res/res_pjsip_pubsub.c:

Line 3003: sprintf
> Why not use snprintf here?
There is no real need to use snprintf() over sprintf() here.  The buffer is always allocated to be the exact size needed so snprintf() doesn't add any safety.


-- 
To view, visit https://gerrit.asterisk.org/1241
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I388688a132e479bca6ad1c19275eae0070969ae2
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Ashley Sanders <asanders at digium.com>
Gerrit-Reviewer: Jonathan Rose <jrose at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes