[Asterisk-code-review] res pjsip: Copy default from user to avoid crash. (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change.

Change subject: res_pjsip: Copy default_from_user to avoid crash.
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/#/c/1235/1/res/res_pjsip/config_global.c
File res/res_pjsip/config_global.c:

Line 185: void ast_sip_get_default_from_user(char *from_user, size_t size)
Why not ast_strdup() the return string like ast_sip_get_endpoint_identifier_order() and others in this file to retrieve config strings instead of copying it into a supplied buffer?


-- 
To view, visit https://gerrit.asterisk.org/1235
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6b96067a495c1259da768f4012d44e03e7c6148c
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes