[Asterisk-code-review] runtests: Add the ability to run the test suite in a loop (testsuite[master])

[Corey Farrell]

Corey Farrell has posted comments on this change.

Change subject: runtests: Add the ability to run the test suite in a loop
......................................................................


Patch Set 3: Code-Review-1

(1 comment)

I have mixed feelings about reusing the '-n' option so quickly.  For moving forward maybe it would be good to document that short options are subject to change, and automated scripts should always use long options only?

My comment about the help message is the reason for -1 review, I'm can be ok with reuse of the short option.

One last thought, the handling of SIGUSR2 seems more appropriate for HUP and/or TERM.  This would leave USR2 available for other use in the future, like abort the current test only but continue with the rest.

https://gerrit.asterisk.org/#/c/1529/3/runtests.py
File runtests.py:

Line 671:                       help="Number of times to run the test suite. -1 loops forever.")
This reads like there is an option '-1' that loops forever, where it's actually '-n-1' or '-n -1'?  At minimum this should say 'Value of -1 loops forever.'


-- 
To view, visit https://gerrit.asterisk.org/1529
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6c65250a45e48dc36b7c4657d4cfbe63efeb1a6d
Gerrit-PatchSet: 3
Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-Owner: Matt Jordan <mjordan at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-HasComments: Yes