[Asterisk-code-review] chan pjsip: Add Referred-By header to the PJSIP REFER packet. (asterisk[master])

[Kevin Harwell]

Kevin Harwell has posted comments on this change.

Change subject: chan_pjsip: Add Referred-By header to the PJSIP REFER packet.
......................................................................


Patch Set 4: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/1149/4/channels/chan_pjsip.c
File channels/chan_pjsip.c:

Line 1460: 		ast_sip_add_header(packet, pj_strbuf(&ref_by), pj_strbuf(&session->inv_session->dlg->local.info_str));
The pointer returned by pj_strbuf is not necessarily null terminated. This can potentially cause a problem within ast_sip_add_header since it expects null terminated strings.


-- 
To view, visit https://gerrit.asterisk.org/1149
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3d17912ce548667edf53cb549e88a25475eda245
Gerrit-PatchSet: 4
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Dan Cropp <dan at amtelco.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-HasComments: Yes