[Asterisk-code-review] main: Slight refactor for in main. Improve color situation. (asterisk[11])
Walter Doekes
asteriskteam at digium.com
Mon Nov 23 13:54:07 CST 2015
Walter Doekes has posted comments on this change.
Change subject: main: Slight refactor for in main. Improve color situation.
......................................................................
Patch Set 1:
(2 comments)
Thanks for the review!
Note to self:
- commitmsg s/refactor for in/refactor in main/
- two other issues mentioned here
https://gerrit.asterisk.org/#/c/1698/1/include/asterisk/term.h
File include/asterisk/term.h:
Line 99
Like mentioned. These changes (and the removal of their definitions) will only go into the master branch.
https://gerrit.asterisk.org/#/c/1698/1/main/asterisk.c
File main/asterisk.c:
Line 3658: void asterisk_daemon(int isroot, const char *runuser, const char *rungroup);
Missed a 'static'. And move it to top of file.
--
To view, visit https://gerrit.asterisk.org/1698
To unsubscribe, visit https://gerrit.asterisk.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib641a0964c59ef9fe6f59efa8ccb481a9580c52f
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 11
Gerrit-Owner: Walter Doekes <walter+asterisk at wjd.nu>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Walter Doekes <walter+asterisk at wjd.nu>
Gerrit-HasComments: Yes
More information about the asterisk-code-review
mailing list