[Asterisk-code-review] testsuite: Allow log files to be disabled by tests. (testsuite[master])

[Matt Jordan]

Matt Jordan has posted comments on this change.

Change subject: testsuite: Allow log files to be disabled by tests.
......................................................................


Patch Set 1: Code-Review-1

(3 comments)

https://gerrit.asterisk.org/#/c/1637/1/lib/python/asterisk/test_case.py
File lib/python/asterisk/test_case.py:

Line 67:     if log_full == 'True':
If these are Boolean values, this can just be:

if log_full:

and

if log_messages:


Line 143:         log_full = 'True'
        :         log_messages = 'True'
Why not use Booleans?


Line 154:             if 'log-full' in test_config:
        :                 log_full = test_config['log-full']
        :             if 'log-messages' in test_config:
        :                 log_messages = test_config['log-messages']
These can just be:

log_full = test_config.get('log-full', True)
log_messages = test_config.get('log-messages', True)


-- 
To view, visit https://gerrit.asterisk.org/1637
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I55924b1f68373204617f26dd2ac8c1cef5ae4468
Gerrit-PatchSet: 1
Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-Owner: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-HasComments: Yes