[Asterisk-code-review] res pjsip: Deny requests when threadpool queue is backed up. (asterisk[13])

[Mark Michelson]

Mark Michelson has posted comments on this change.

Change subject: res_pjsip: Deny requests when threadpool queue is backed up.
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/#/c/1607/1/res/res_pjsip/pjsip_distributor.c
File res/res_pjsip/pjsip_distributor.c:

Line 249: #define SIP_MAX_QUEUE 500l
> The max queue size is technically an implementation detail of the threadpoo
I'm not sure I understand this finding. The max queue size isn't actually an implementation detail of the threadpool. The size of the queue certainly is, but not the maximum size.

Plus, in this usage, the maximum queue length still isn't intrinsic to the threadpool itself. Rather, it is in this one usage of the threadpool that we limit its use based on queue size.


-- 
To view, visit https://gerrit.asterisk.org/1607
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4e736d48a2ba79fd1f8056c0dcd330e38e6a3816
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes