[Asterisk-code-review] ast format cap get names: To display all formats, the buffer... (asterisk[13])

Corey Farrell asteriskteam at digium.com
Mon Nov 9 05:21:52 CST 2015


Corey Farrell has posted comments on this change.

Change subject: ast_format_cap_get_names: To display all formats, the buffer was increased.
......................................................................


Patch Set 1: Code-Review-1

If we're going to move forward with this I'd like to see a macro #define instead of 384 all over the place.  This way if it's decided that the number needs to change again we can do so in one place.  If someone is running on a stack constrained system they would be able to redefine the macro with a smaller value.  Might be good to define a lower value '#ifdef LOW_MEMORY'.

-- 
To view, visit https://gerrit.asterisk.org/1588
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I590a3f7232cecc1dcd4fffe49525266a7a777c80
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-HasComments: No



More information about the asterisk-code-review mailing list