[Asterisk-code-review] cel, cdr: Assigned separator for column name and values. (asterisk[master])

Ashley Sanders asteriskteam at digium.com
Tue May 19 12:04:11 CDT 2015


Ashley Sanders has posted comments on this change.

Change subject: cel, cdr: Assigned separator for column name and values.
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.asterisk.org/#/c/469/3//COMMIT_MSG
Commit Message:

Line 19: Change-Id: Ia5a1a161f5e26e1643703b30f8cc9cf0860cc7ea
> This change dont have a issue. Is a similar change of 46bb8449e8a7e174b62f5
Yes, I believe that an issue should be created. Here are a couple of reasons why:

- The release scripts examine the Asterisk git tree for changes that have associated issues and publishes those as part of the changes list. In order for end-users to be aware of the delta between releases, an issue to map to the commit is required.

- Having issues makes it easier for us developers to trace commits to a requirement and also provides substantiation for the change. In the event that something catastrophic fails (or maybe it was just the build that failed), having this level of traceability is essential for the us to be able to expeditiously diagnose and correct the problem.


-- 
To view, visit https://gerrit.asterisk.org/469
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia5a1a161f5e26e1643703b30f8cc9cf0860cc7ea
Gerrit-PatchSet: 3
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Rodrigo Ramirez Norambuena <decipher.hk at gmail.com>
Gerrit-Reviewer: Ashley Sanders <asanders at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Rodrigo Ramirez Norambuena <decipher.hk at gmail.com>
Gerrit-HasComments: Yes



More information about the asterisk-code-review mailing list