[Asterisk-code-review] tcptls: Enable multiple TLS certificate chains (RSA+ECC+DSA)... (asterisk[master])

[Joshua Colp]

Joshua Colp has posted comments on this change.

Change subject: tcptls: Enable multiple TLS certificate chains (RSA+ECC+DSA) for server socket.
......................................................................


Patch Set 5:

(1 comment)

As for loaded versus looked for, I personally like loaded.

https://gerrit.asterisk.org/#/c/431/5/configs/samples/pjsip.conf.sample
File configs/samples/pjsip.conf.sample:

Line 769:                 ; Since PJProject version 2.5: If the file name ends in _rsa,
        :                 ; for example "asterisk_rsa.pem", the files "asterisk_dsa.pem"
        :                 ; and/or "asterisk_ecc.pem" are loaded (certificate, inter-
        :                 ; mediates, private key), to support multiple algorithms for
        :                 ; server authentication (RSA, DSA, ECDSA). If the chains are
        :                 ; different, at least OpenSSL 1.0.2 is required.
This documentation should be put into 13 as well since it's applicable there.


-- 
To view, visit https://gerrit.asterisk.org/431
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iada5e00d326db5ef86e0af7069b4dfa1b979da9a
Gerrit-PatchSet: 5
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Ashley Sanders <asanders at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes