[Asterisk-code-review] vector: Traversal, retrieval, insert and locking enhancements (asterisk[13])

[Corey Farrell]

Corey Farrell has posted comments on this change.

Change subject: vector:  Traversal, retrieval, insert and locking enhancements
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/339/1/include/asterisk/vector.h
File include/asterisk/vector.h:

Line 205: #define AST_VECTOR_REPLACE(vec, idx, elem) ({					\
This rename seems like a problem for Asterisk 13, especially with the new AST_VECTOR_INSERT.  The problem is that any unchanged call to AST_VECTOR_INSERT will do something completely different.

I do like the rename, but it just seems like an issue for released branches.  For master I think we need a note in CHANGES or something.  My concern even for master is the lack of compiler error for using AST_VECTOR_INSERT.


-- 
To view, visit https://gerrit.asterisk.org/339
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2e07ecc709d2f5f91bcab8904e5e9340609b00e0
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: George Joseph <george.joseph at fairview5.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-HasComments: Yes