[Asterisk-code-review] main/pbx: Improve performance of dialplan reloads with a lar... (asterisk[13])

[Matt Jordan]

Matt Jordan has posted comments on this change.

Change subject: main/pbx: Improve performance of dialplan reloads with a large number of hints
......................................................................


Patch Set 5:

(2 comments)

https://gerrit.asterisk.org/#/c/312/5/main/pbx.c
File main/pbx.c:

Line 1166: 		if (!device) {
         : 			continue;
         : 		}
> can device ever be NULL now?
Good point. It should not ever be NULL; I'll remove it.


Line 1173: 		ao2_t_callback(hintdevices, OBJ_SEARCH_KEY | OBJ_UNLINK | OBJ_NODATA,
         : 			hintdevice_remove_cb, &remove_data, "Remove device from container");
> Use ao2_t_callback_data() instead.  The remove_data struct is not going to 
Yeah, that will be a lot better, since I won't need a custom struct either.


-- 
To view, visit https://gerrit.asterisk.org/312
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iedfc97a69d21070c50fca42275d7b3e714e59360
Gerrit-PatchSet: 5
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Matt Jordan <mjordan at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes