[Asterisk-code-review] Move extra modules.conf settings to modules.conf.inc. (testsuite[master])

[Corey Farrell]

Corey Farrell has posted comments on this change.

Change subject: Move extra modules.conf settings to modules.conf.inc.
......................................................................


Patch Set 2:

> I'm not against this but curious what prompted this change.
 > 
 > As well - the wiki should probably be updated to include this as
 > the pattern going forward for modules.conf usage in tests.

Sorry I missed your message.  It was actually tests/channels/SIP/noload_res_srtp that prompted this change.  It did not include 'noload=chan_console.so', that module has some reference leaks.  This caused me to assume that replacing modules.conf as a whole could cause other issues like this in the future.

As for the wiki I'm not sure what section this should be mentioned in.  Maybe we need a new page with details on how to add settings to Asterisk config files like modules.conf.

-- 
To view, visit https://gerrit.asterisk.org/668
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6cf431d0ea110293f766c1e070050914d75b6611
Gerrit-PatchSet: 2
Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-HasComments: No