[Asterisk-code-review] Unit tests: Fix unit test description strings. (asterisk[master])
Joshua Colp
asteriskteam at digium.com
Thu Jun 25 04:48:46 CDT 2015
Joshua Colp has submitted this change and it was merged.
Change subject: Unit tests: Fix unit test description strings.
......................................................................
Unit tests: Fix unit test description strings.
Analyzing the code shows that the unit test summary and description
strings should not end with a new-line character. Where these strings are
used in the code a new-line is provided for output.
Change-Id: I129284f5e7ca93d82532334076da4c462d3d9fba
---
M tests/test_cdr.c
M tests/test_cel.c
M tests/test_channel_feature_hooks.c
M tests/test_expr.c
M tests/test_format_cap.c
M tests/test_message.c
M tests/test_poll.c
M tests/test_sorcery_realtime.c
M tests/test_stasis.c
M tests/test_threadpool.c
M tests/test_voicemail_api.c
11 files changed, 78 insertions(+), 78 deletions(-)
Approvals:
Mark Michelson: Looks good to me, but someone else must approve
Matt Jordan: Looks good to me, but someone else must approve
Joshua Colp: Looks good to me, approved; Verified
diff --git a/tests/test_cdr.c b/tests/test_cdr.c
index 9c982e2..ef9e76d 100644
--- a/tests/test_cdr.c
+++ b/tests/test_cdr.c
@@ -463,7 +463,7 @@
info->description =
"Test the properties of a CDR for a call that is\n"
"inbound to Asterisk, executes some dialplan, but\n"
- "is never answered.\n";
+ "is never answered.";
return AST_TEST_NOT_RUN;
case TEST_EXECUTE:
break;
@@ -513,7 +513,7 @@
info->summary = "Test outbound unanswered calls";
info->description =
"Test the properties of a CDR for a call that is\n"
- "outbound to Asterisk but is never answered.\n";
+ "outbound to Asterisk but is never answered.";
return AST_TEST_NOT_RUN;
case TEST_EXECUTE:
break;
@@ -583,7 +583,7 @@
info->category = TEST_CATEGORY;
info->summary = "Test dialing, answering, and going into a 2-party bridge";
info->description =
- "The most 'basic' of scenarios\n";
+ "The most 'basic' of scenarios";
return AST_TEST_NOT_RUN;
case TEST_EXECUTE:
break;
@@ -662,7 +662,7 @@
info->summary = "Test cdrs for a single party";
info->description =
"Test the properties of a CDR for a call that is\n"
- "answered, but only involves a single channel\n";
+ "answered, but only involves a single channel";
return AST_TEST_NOT_RUN;
case TEST_EXECUTE:
break;
@@ -713,7 +713,7 @@
info->summary = "Test cdrs for a single party entering/leaving a bridge";
info->description =
"Test the properties of a CDR for a call that is\n"
- "answered, enters a bridge, and leaves it.\n";
+ "answered, enters a bridge, and leaves it.";
return AST_TEST_NOT_RUN;
case TEST_EXECUTE:
break;
@@ -788,7 +788,7 @@
info->summary = "Test cdrs for a single party entering/leaving a bridge";
info->description =
"Test the properties of a CDR for a call that is\n"
- "answered, enters a bridge, and leaves it.\n";
+ "answered, enters a bridge, and leaves it.";
return AST_TEST_NOT_RUN;
case TEST_EXECUTE:
break;
@@ -872,7 +872,7 @@
info->description =
"Test the properties of a CDR for a call that is\n"
"answered, enters a bridge, and leaves it. In this scenario, the\n"
- "Party A should answer the bridge first.\n";
+ "Party A should answer the bridge first.";
return AST_TEST_NOT_RUN;
case TEST_EXECUTE:
break;
@@ -964,7 +964,7 @@
info->description =
"Test the properties of a CDR for a call that is\n"
"answered, enters a bridge, and leaves it. In this scenario, the\n"
- "Party B should answer the bridge first.\n";
+ "Party B should answer the bridge first.";
return AST_TEST_NOT_RUN;
case TEST_EXECUTE:
break;
@@ -1089,7 +1089,7 @@
info->description =
"Test the properties of a CDR for a call that is\n"
"answered, enters a bridge, and leaves it. A total of three\n"
- "parties perform this action.\n";
+ "parties perform this action.";
return AST_TEST_NOT_RUN;
case TEST_EXECUTE:
break;
@@ -1179,7 +1179,7 @@
info->summary = "Test CDRs for a dial that isn't answered";
info->description =
"Test the properties of a CDR for a channel that\n"
- "performs a dial operation that isn't answered\n";
+ "performs a dial operation that isn't answered";
return AST_TEST_NOT_RUN;
case TEST_EXECUTE:
break;
@@ -1242,7 +1242,7 @@
info->summary = "Test CDRs for a dial that results in a busy";
info->description =
"Test the properties of a CDR for a channel that\n"
- "performs a dial operation to an endpoint that's busy\n";
+ "performs a dial operation to an endpoint that's busy";
return AST_TEST_NOT_RUN;
case TEST_EXECUTE:
break;
@@ -1304,7 +1304,7 @@
info->summary = "Test CDRs for a dial that results in congestion";
info->description =
"Test the properties of a CDR for a channel that\n"
- "performs a dial operation to an endpoint that's congested\n";
+ "performs a dial operation to an endpoint that's congested";
return AST_TEST_NOT_RUN;
case TEST_EXECUTE:
break;
@@ -1366,7 +1366,7 @@
info->summary = "Test CDRs for a dial that results in unavailable";
info->description =
"Test the properties of a CDR for a channel that\n"
- "performs a dial operation to an endpoint that's unavailable\n";
+ "performs a dial operation to an endpoint that's unavailable";
return AST_TEST_NOT_RUN;
case TEST_EXECUTE:
break;
@@ -1429,7 +1429,7 @@
info->description =
"Test the properties of a CDR for a channel that\n"
"performs a dial operation to an endpoint but then decides\n"
- "to hang up, cancelling the dial\n";
+ "to hang up, cancelling the dial";
return AST_TEST_NOT_RUN;
case TEST_EXECUTE:
break;
@@ -1528,7 +1528,7 @@
info->description =
"This tests dialing three parties: Bob, Charlie, David. Charlie\n"
"returns BUSY; David returns CONGESTION; Bob fails to answer and\n"
- "Alice hangs up. Three records are created for Alice as a result.\n";
+ "Alice hangs up. Three records are created for Alice as a result.";
return AST_TEST_NOT_RUN;
case TEST_EXECUTE:
break;
@@ -1650,7 +1650,7 @@
"when we answer, we get a CDR, it gets ended at that point, and\n"
"that it gets finalized appropriately. We should get three CDRs in\n"
"the end - one for the dial, and one for each CDR as they continued\n"
- "on.\n";
+ "on.";
return AST_TEST_NOT_RUN;
case TEST_EXECUTE:
break;
@@ -1720,7 +1720,7 @@
info->category = TEST_CATEGORY;
info->summary = "Test dialing, answering, and going into a 2-party bridge";
info->description =
- "The most 'basic' of scenarios\n";
+ "The most 'basic' of scenarios";
return AST_TEST_NOT_RUN;
case TEST_EXECUTE:
break;
@@ -1797,7 +1797,7 @@
info->category = TEST_CATEGORY;
info->summary = "Test dialing, answering, and going into a 2-party bridge";
info->description =
- "The most 'basic' of scenarios\n";
+ "The most 'basic' of scenarios";
return AST_TEST_NOT_RUN;
case TEST_EXECUTE:
break;
@@ -1955,7 +1955,7 @@
info->category = TEST_CATEGORY;
info->summary = "Test dialing, answering, and going into a multi-party bridge";
info->description =
- "A little tricky to get to do, but possible with some redirects.\n";
+ "A little tricky to get to do, but possible with some redirects.";
return AST_TEST_NOT_RUN;
case TEST_EXECUTE:
break;
@@ -2076,7 +2076,7 @@
info->summary = "Test cdrs for a single party entering Park";
info->description =
"Test the properties of a CDR for calls that are\n"
- "answered, enters Park, and leaves it.\n";
+ "answered, enters Park, and leaves it.";
return AST_TEST_NOT_RUN;
case TEST_EXECUTE:
break;
@@ -2184,7 +2184,7 @@
info->category = TEST_CATEGORY;
info->summary = "Test field access CDRs";
info->description =
- "This tests setting/retrieving data on CDR records.\n";
+ "This tests setting/retrieving data on CDR records.";
return AST_TEST_NOT_RUN;
case TEST_EXECUTE:
break;
@@ -2351,7 +2351,7 @@
info->category = TEST_CATEGORY;
info->summary = "Test field access CDRs";
info->description =
- "This tests setting/retrieving data on CDR records.\n";
+ "This tests setting/retrieving data on CDR records.";
return AST_TEST_NOT_RUN;
case TEST_EXECUTE:
break;
@@ -2449,7 +2449,7 @@
info->category = TEST_CATEGORY;
info->summary = "Test field access CDRs";
info->description =
- "This tests setting/retrieving data on CDR records.\n";
+ "This tests setting/retrieving data on CDR records.";
return AST_TEST_NOT_RUN;
case TEST_EXECUTE:
break;
diff --git a/tests/test_cel.c b/tests/test_cel.c
index 71fc636..0cd8c5c 100644
--- a/tests/test_cel.c
+++ b/tests/test_cel.c
@@ -430,7 +430,7 @@
info->description =
"Test CEL records for a call that is\n"
"inbound to Asterisk, executes some dialplan, but\n"
- "is never answered.\n";
+ "is never answered.";
return AST_TEST_NOT_RUN;
case TEST_EXECUTE:
break;
@@ -461,7 +461,7 @@
info->summary = "Test outbound unanswered calls";
info->description =
"Test CEL records for a call that is\n"
- "outbound to Asterisk but is never answered.\n";
+ "outbound to Asterisk but is never answered.";
return AST_TEST_NOT_RUN;
case TEST_EXECUTE:
break;
@@ -490,7 +490,7 @@
info->summary = "Test CEL for a single party";
info->description =
"Test CEL records for a call that is\n"
- "answered, but only involves a single channel\n";
+ "answered, but only involves a single channel";
return AST_TEST_NOT_RUN;
case TEST_EXECUTE:
break;
@@ -519,7 +519,7 @@
info->summary = "Test CEL for a single party entering/leaving a bridge";
info->description =
"Test CEL records for a call that is\n"
- "answered, enters a bridge, and leaves it.\n";
+ "answered, enters a bridge, and leaves it.";
return AST_TEST_NOT_RUN;
case TEST_EXECUTE:
break;
@@ -557,7 +557,7 @@
info->summary = "Test CEL for a single party entering/leaving a bridge";
info->description =
"Test CEL records for a call that is\n"
- "answered, enters a bridge, and leaves it.\n";
+ "answered, enters a bridge, and leaves it.";
return AST_TEST_NOT_RUN;
case TEST_EXECUTE:
break;
@@ -601,7 +601,7 @@
info->description =
"Test CEL records for a call that is\n"
"answered, enters a bridge, and leaves it. In this scenario, the\n"
- "Party A should answer the bridge first.\n";
+ "Party A should answer the bridge first.";
return AST_TEST_NOT_RUN;
case TEST_EXECUTE:
break;
@@ -649,7 +649,7 @@
info->description =
"Test CEL records for a call that is\n"
"answered, enters a bridge, and leaves it. In this scenario, the\n"
- "Party B should answer the bridge first.\n";
+ "Party B should answer the bridge first.";
return AST_TEST_NOT_RUN;
case TEST_EXECUTE:
break;
@@ -703,7 +703,7 @@
info->description =
"Test CEL records for a call that is\n"
"answered, enters a bridge, and leaves it. A total of three\n"
- "parties perform this action.\n";
+ "parties perform this action.";
return AST_TEST_NOT_RUN;
case TEST_EXECUTE:
break;
@@ -780,7 +780,7 @@
info->summary = "Test CEL for a dial that isn't answered";
info->description =
"Test CEL records for a channel that\n"
- "performs a dial operation that isn't answered\n";
+ "performs a dial operation that isn't answered";
return AST_TEST_NOT_RUN;
case TEST_EXECUTE:
break;
@@ -814,7 +814,7 @@
info->summary = "Test CEL for a dial that isn't answered";
info->description =
"Test CEL records for a channel that\n"
- "performs a dial operation that isn't answered\n";
+ "performs a dial operation that isn't answered";
return AST_TEST_NOT_RUN;
case TEST_EXECUTE:
break;
@@ -849,7 +849,7 @@
info->summary = "Test CEL for a dial that results in a busy";
info->description =
"Test CEL records for a channel that\n"
- "performs a dial operation to an endpoint that's busy\n";
+ "performs a dial operation to an endpoint that's busy";
return AST_TEST_NOT_RUN;
case TEST_EXECUTE:
break;
@@ -883,7 +883,7 @@
info->summary = "Test CEL for a dial that results in congestion";
info->description =
"Test CEL records for a channel that\n"
- "performs a dial operation to an endpoint that's congested\n";
+ "performs a dial operation to an endpoint that's congested";
return AST_TEST_NOT_RUN;
case TEST_EXECUTE:
break;
@@ -917,7 +917,7 @@
info->summary = "Test CEL for a dial that results in unavailable";
info->description =
"Test CEL records for a channel that\n"
- "performs a dial operation to an endpoint that's unavailable\n";
+ "performs a dial operation to an endpoint that's unavailable";
return AST_TEST_NOT_RUN;
case TEST_EXECUTE:
break;
@@ -952,7 +952,7 @@
info->description =
"Test CEL records for a channel that\n"
"performs a dial operation to an endpoint but then decides\n"
- "to hang up, cancelling the dial\n";
+ "to hang up, cancelling the dial";
return AST_TEST_NOT_RUN;
case TEST_EXECUTE:
break;
@@ -989,7 +989,7 @@
info->description =
"This tests dialing three parties: Bob, Charlie, David. Charlie\n"
"returns BUSY; David returns CONGESTION; Bob fails to answer and\n"
- "Alice hangs up. Three records are created for Alice as a result.\n";
+ "Alice hangs up. Three records are created for Alice as a result.";
return AST_TEST_NOT_RUN;
case TEST_EXECUTE:
break;
@@ -1042,7 +1042,7 @@
"a dial, then bounce both channels to different priorities and\n"
"never have them enter a bridge together. Ew. This makes sure that\n"
"when we answer, we get a CEL, it gets ended at that point, and\n"
- "that it gets finalized appropriately.\n";
+ "that it gets finalized appropriately.";
return AST_TEST_NOT_RUN;
case TEST_EXECUTE:
break;
@@ -1083,7 +1083,7 @@
info->category = TEST_CATEGORY;
info->summary = "Test dialing, answering, and going into a 2-party bridge";
info->description =
- "The most 'basic' of scenarios\n";
+ "The most 'basic' of scenarios";
return AST_TEST_NOT_RUN;
case TEST_EXECUTE:
break;
@@ -1130,7 +1130,7 @@
info->category = TEST_CATEGORY;
info->summary = "Test dialing, answering, and going into a 2-party bridge";
info->description =
- "The most 'basic' of scenarios\n";
+ "The most 'basic' of scenarios";
return AST_TEST_NOT_RUN;
case TEST_EXECUTE:
break;
@@ -1180,7 +1180,7 @@
info->category = TEST_CATEGORY;
info->summary = "Test dialing, answering, and going into a multi-party bridge";
info->description =
- "A little tricky to get to do, but possible with some redirects.\n";
+ "A little tricky to get to do, but possible with some redirects.";
return AST_TEST_NOT_RUN;
case TEST_EXECUTE:
break;
@@ -1256,7 +1256,7 @@
info->summary = "Test blind transfers to an extension";
info->description =
"This test creates two channels, bridges them, and then"
- " blind transfers the bridge to an extension.\n";
+ " blind transfers the bridge to an extension.";
return AST_TEST_NOT_RUN;
case TEST_EXECUTE:
break;
@@ -1327,7 +1327,7 @@
info->description =
"This test creates four channels, places each pair in"
" a bridge, and then attended transfers the bridges"
- " together.\n";
+ " together.";
return AST_TEST_NOT_RUN;
case TEST_EXECUTE:
break;
@@ -1409,7 +1409,7 @@
info->description =
"This test creates four channels, places each pair"
" in a bridge, and then attended transfers the bridges"
- " together causing a bridge merge.\n";
+ " together causing a bridge merge.";
return AST_TEST_NOT_RUN;
case TEST_EXECUTE:
break;
@@ -1497,7 +1497,7 @@
info->description =
"This test creates four channels, places each pair"
" in a bridge, and then attended transfers the bridges"
- " together causing a bridge link.\n";
+ " together causing a bridge link.";
return AST_TEST_NOT_RUN;
case TEST_EXECUTE:
break;
@@ -1577,7 +1577,7 @@
info->description =
"Test CEL records for a call that is\n"
"inbound to Asterisk, executes some dialplan, and\n"
- "is picked up.\n";
+ "is picked up.";
return AST_TEST_NOT_RUN;
case TEST_EXECUTE:
break;
@@ -1637,7 +1637,7 @@
info->description =
"Test CEL records for two local channels being optimized\n"
"out by sending a messages indicating local optimization\n"
- "begin and end\n";
+ "begin and end";
return AST_TEST_NOT_RUN;
case TEST_EXECUTE:
break;
diff --git a/tests/test_channel_feature_hooks.c b/tests/test_channel_feature_hooks.c
index 8faaf9f..ad72688 100644
--- a/tests/test_channel_feature_hooks.c
+++ b/tests/test_channel_feature_hooks.c
@@ -169,7 +169,7 @@
info->description =
"This test creates two channels, adds a DTMF hook to one, places them into\n"
"a bridge, and verifies that the DTMF hook added to the channel feature\n"
- "hooks can be triggered once the channel is bridged.\n";
+ "hooks can be triggered once the channel is bridged.";
return AST_TEST_NOT_RUN;
case TEST_EXECUTE:
break;
@@ -261,7 +261,7 @@
info->description =
"This test creates two channels, adds an interval hook to one, places them\n"
"into a bridge, and verifies that the interval hook added to the channel\n"
- "feature hooks is triggered once the channel is bridged.\n";
+ "feature hooks is triggered once the channel is bridged.";
return AST_TEST_NOT_RUN;
case TEST_EXECUTE:
break;
diff --git a/tests/test_expr.c b/tests/test_expr.c
index c215559..5ea86a3 100644
--- a/tests/test_expr.c
+++ b/tests/test_expr.c
@@ -158,7 +158,7 @@
info->category = "/main/ast_expr/";
info->summary = "unit test for the internal expression engine";
info->description =
- "Verifies behavior for the internal expression engine\n";
+ "Verifies behavior for the internal expression engine";
return AST_TEST_NOT_RUN;
case TEST_EXECUTE:
break;
diff --git a/tests/test_format_cap.c b/tests/test_format_cap.c
index 76b1549..4d810bf 100644
--- a/tests/test_format_cap.c
+++ b/tests/test_format_cap.c
@@ -1088,7 +1088,7 @@
info->summary = "Test getting the names of formats";
info->description =
"Test that obtaining the names from a format capabilities structure\n"
- "produces the expected output.\n";
+ "produces the expected output.";
return AST_TEST_NOT_RUN;
case TEST_EXECUTE:
break;
diff --git a/tests/test_message.c b/tests/test_message.c
index 2c9334a..3c3b830 100644
--- a/tests/test_message.c
+++ b/tests/test_message.c
@@ -310,7 +310,7 @@
info->description =
"Test that:\n"
"\tA message technology can be registered once only\n"
- "\tA registered message technology can be unregistered once only\n";
+ "\tA registered message technology can be unregistered once only";
return AST_TEST_NOT_RUN;
case TEST_EXECUTE:
break;
@@ -343,7 +343,7 @@
info->description =
"Test that:\n"
"\tA message handler can be registered once only\n"
- "\tA registered message handler can be unregistered once only\n";
+ "\tA registered message handler can be unregistered once only";
return AST_TEST_NOT_RUN;
case TEST_EXECUTE:
break;
@@ -391,7 +391,7 @@
"This test covers the following:\n"
"\tSetting/getting the body\n"
"\tSetting/getting inbound/outbound variables\n"
- "\tIterating over variables\n";
+ "\tIterating over variables";
return AST_TEST_NOT_RUN;
case TEST_EXECUTE:
break;
@@ -477,7 +477,7 @@
info->summary = "Test enqueueing messages to the dialplan";
info->description =
"Test that a message enqueued for the dialplan is\n"
- "passed to that particular extension\n";
+ "passed to that particular extension";
return AST_TEST_NOT_RUN;
case TEST_EXECUTE:
break;
@@ -548,7 +548,7 @@
info->summary = "Test enqueueing messages to a handler";
info->description =
"Test that a message enqueued can be handled by a\n"
- "non-dialplan handler\n";
+ "non-dialplan handler";
return AST_TEST_NOT_RUN;
case TEST_EXECUTE:
break;
@@ -591,7 +591,7 @@
info->description =
"Test that a message enqueued is passed to all\n"
"handlers that can process it, dialplan as well as\n"
- "a custom handler\n";
+ "a custom handler";
return AST_TEST_NOT_RUN;
case TEST_EXECUTE:
break;
@@ -662,7 +662,7 @@
info->summary = "Test checking for a dialplan destination";
info->description =
"Test that a message's destination is verified via the\n"
- "dialplan\n";
+ "dialplan";
return AST_TEST_NOT_RUN;
case TEST_EXECUTE:
break;
@@ -704,7 +704,7 @@
info->summary = "Test checking for a handler destination";
info->description =
"Test that a message's destination is verified via a\n"
- "handler\n";
+ "handler";
return AST_TEST_NOT_RUN;
case TEST_EXECUTE:
break;
@@ -744,7 +744,7 @@
info->summary = "Test message routing";
info->description =
"Test that a message can be routed if it has\n"
- "a valid handler\n";
+ "a valid handler";
return AST_TEST_NOT_RUN;
case TEST_EXECUTE:
break;
diff --git a/tests/test_poll.c b/tests/test_poll.c
index e71913c..10b0225 100644
--- a/tests/test_poll.c
+++ b/tests/test_poll.c
@@ -88,7 +88,7 @@
info->category = "/main/poll/";
info->summary = "unit test for the ast_poll() API";
info->description =
- "Verifies behavior for the ast_poll() API call\n";
+ "Verifies behavior for the ast_poll() API call";
return AST_TEST_NOT_RUN;
case TEST_EXECUTE:
break;
diff --git a/tests/test_sorcery_realtime.c b/tests/test_sorcery_realtime.c
index fe7ea52..347280d 100644
--- a/tests/test_sorcery_realtime.c
+++ b/tests/test_sorcery_realtime.c
@@ -821,7 +821,7 @@
"realtime backend that is unknown to sorcery. When sorcery attempts to retrieve\n"
"the object from the realtime backend, the data unknown to sorcery should be\n"
"filtered out of the returned objectset, and the object should be successfully\n"
- "allocated by sorcery\n";
+ "allocated by sorcery";
return AST_TEST_NOT_RUN;
case TEST_EXECUTE:
break;
diff --git a/tests/test_stasis.c b/tests/test_stasis.c
index b5755c8..806fbf8 100644
--- a/tests/test_stasis.c
+++ b/tests/test_stasis.c
@@ -789,7 +789,7 @@
"and publishes messages alternately between the children.\n"
"It verifies that the messages are received in the expected\n"
"order, for different subscription types: one with a dedicated\n"
- "thread, the other on the Stasis threadpool.\n";
+ "thread, the other on the Stasis threadpool.";
return AST_TEST_NOT_RUN;
case TEST_EXECUTE:
break;
@@ -1618,7 +1618,7 @@
info->summary = "Test message routing via threadpool";
info->description = "Test simple message routing when\n"
"the subscriptions dictate usage of the Stasis\n"
- "threadpool.\n";
+ "threadpool.";
return AST_TEST_NOT_RUN;
case TEST_EXECUTE:
break;
diff --git a/tests/test_threadpool.c b/tests/test_threadpool.c
index 79b369d..f5b1073 100644
--- a/tests/test_threadpool.c
+++ b/tests/test_threadpool.c
@@ -858,7 +858,7 @@
info->description =
"Create an empty threadpool and push a task to it. Once the task is\n"
"pushed, the threadpool should add three threads and be able to\n"
- "handle the task. The threads should then go idle\n";
+ "handle the task. The threads should then go idle";
return AST_TEST_NOT_RUN;
case TEST_EXECUTE:
break;
@@ -972,7 +972,7 @@
info->description =
"Create an empty threadpool and push a task to it. Once the task is\n"
"pushed, the threadpool should attempt to grow by three threads, but the\n"
- "pool's restrictions should only allow two threads to be added.\n";
+ "pool's restrictions should only allow two threads to be added.";
return AST_TEST_NOT_RUN;
case TEST_EXECUTE:
break;
@@ -1043,7 +1043,7 @@
info->description =
"Push a task into a threadpool. Make sure the task executes and the\n"
"thread goes idle. Then push a second task and ensure that the thread\n"
- "awakens and executes the second task.\n";
+ "awakens and executes the second task.";
return AST_TEST_NOT_RUN;
case TEST_EXECUTE:
break;
@@ -1250,7 +1250,7 @@
info->summary = "Test that tasks are evenly distributed to threads";
info->description =
"Push two tasks into a threadpool. Ensure that each is handled by\n"
- "a separate thread\n";
+ "a separate thread";
return AST_TEST_NOT_RUN;
case TEST_EXECUTE:
break;
@@ -1346,7 +1346,7 @@
"Push two tasks into a threadpool. Set the threadpool size to 4\n"
"Ensure that there are 2 active and 2 idle threads. Then shrink the\n"
"threadpool down to 1 thread. Ensure that the thread leftover is active\n"
- "and ensure that both tasks complete.\n";
+ "and ensure that both tasks complete.";
return AST_TEST_NOT_RUN;
case TEST_EXECUTE:
break;
@@ -1456,7 +1456,7 @@
info->category = "/main/threadpool/";
info->summary = "Test that serializers";
info->description =
- "Ensures that tasks enqueued to a serialize execute in sequence.\n";
+ "Ensures that tasks enqueued to a serialize execute in sequence.";
return AST_TEST_NOT_RUN;
case TEST_EXECUTE:
break;
@@ -1570,7 +1570,7 @@
info->summary = "Test that serializers are uniquely named";
info->description =
"Creating two serializers with the same name should\n"
- "result in error.\n";
+ "result in error.";
return AST_TEST_NOT_RUN;
case TEST_EXECUTE:
break;
diff --git a/tests/test_voicemail_api.c b/tests/test_voicemail_api.c
index e13b304..fc371ba 100644
--- a/tests/test_voicemail_api.c
+++ b/tests/test_voicemail_api.c
@@ -940,7 +940,7 @@
" * Access to non-existent context\n"
" * Access to non-existent folder\n"
" * Access to NULL folder\n"
- " * Invalid sort identifier\n";
+ " * Invalid sort identifier";
return AST_TEST_NOT_RUN;
case TEST_EXECUTE:
break;
@@ -1054,7 +1054,7 @@
" * Moving to a non-existent context\n"
" * Moving to/from non-existent folder\n"
" * Moving to/from NULL folder\n"
- " * Invalid message identifier(s)\n";
+ " * Invalid message identifier(s)";
return AST_TEST_NOT_RUN;
case TEST_EXECUTE:
break;
@@ -1173,7 +1173,7 @@
" * Removing messages from an invalid context\n"
" * Removing messages from an invalid folder\n"
" * Removing messages from a NULL folder\n"
- " * Removing messages with bad identifiers\n";
+ " * Removing messages with bad identifiers";
return AST_TEST_NOT_RUN;
case TEST_EXECUTE:
break;
@@ -1348,7 +1348,7 @@
" * Invalid to context\n"
" * Invalid/NULL to folder\n"
" * Invalid message numbers\n"
- " * Invalid number of messages\n";
+ " * Invalid number of messages";
return AST_TEST_NOT_RUN;
case TEST_EXECUTE:
break;
@@ -1426,7 +1426,7 @@
info->summary = "Nominal message playback";
info->description =
"Tests playing back a message on a provided"
- " channel or callback function\n";
+ " channel or callback function";
return AST_TEST_NOT_RUN;
case TEST_EXECUTE:
break;
@@ -1488,7 +1488,7 @@
" * Invalid/NULL mailbox\n"
" * Invalid context\n"
" * Invalid/NULL folder\n"
- " * Invalid message identifiers\n";
+ " * Invalid message identifiers";
return AST_TEST_NOT_RUN;
case TEST_EXECUTE:
break;
--
To view, visit https://gerrit.asterisk.org/717
To unsubscribe, visit https://gerrit.asterisk.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I129284f5e7ca93d82532334076da4c462d3d9fba
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
More information about the asterisk-code-review
mailing list