[Asterisk-code-review] res/res pjsip nat: Rewrite route set when required. (asterisk[master])

[Matt Jordan]

Matt Jordan has posted comments on this change.

Change subject: res/res_pjsip_nat: Rewrite route set when required.
......................................................................


Patch Set 4:

(1 comment)

https://gerrit.asterisk.org/#/c/711/4/res/res_pjsip_nat.c
File res/res_pjsip_nat.c:

Line 106: 
        : 	if (endpoint->nat.rewrite_contact) {
        : 		if (rewrite_route_set(rdata, dlg)) {
        : 			rewrite_contact(rdata, dlg);
Since the actual act of rewriting the route/contact requires some reasonable manipulation of the PJSIP data structures, a comment explaining why we do things in this order may be helpful.


-- 
To view, visit https://gerrit.asterisk.org/711
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9702157c3603a2d0bd8a8215ac27564d366b666f
Gerrit-PatchSet: 4
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-HasComments: Yes