[Asterisk-code-review] res pjsip outbound registration.c: Make use a serializer shu... (asterisk[13])
Matt Jordan
asteriskteam at digium.com
Tue Jun 23 07:11:25 CDT 2015
Matt Jordan has posted comments on this change.
Change subject: res_pjsip_outbound_registration.c: Make use a serializer shutdown group.
......................................................................
Patch Set 1:
(2 comments)
https://gerrit.asterisk.org/#/c/691/1//COMMIT_MSG
Commit Message:
Line 7: Make use
'Make use' is a little awkward. Maybe 'Add a ...'?
https://gerrit.asterisk.org/#/c/691/1/res/res_pjsip_outbound_registration.c
File res/res_pjsip_outbound_registration.c:
Line 1828: ast_debug(1, "Waiting for things to settle to unload.\n");
Two suggestions:
(1) I'd make this a slightly higher debug
(2) "Things to settle" is ambiguous. "Pending outbound registrations" maybe?
--
To view, visit https://gerrit.asterisk.org/691
To unsubscribe, visit https://gerrit.asterisk.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb2fe558f98190f2a06da830e0fadfa25516f547
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-HasComments: Yes
More information about the asterisk-code-review
mailing list