[Asterisk-code-review] ASTERISK-24146 (asterisk[11.18])

[Joshua Colp]

Joshua Colp has posted comments on this change.

Change subject: ASTERISK-24146
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

This change is also against the 11.18 release and not the 11 branch. Once a release is released it is not changed.

https://gerrit.asterisk.org/#/c/678/1/res/res_rtp_asterisk.c
File res/res_rtp_asterisk.c:

Line 1593: static void ast_rtp_on_ice_complete(pj_ice_sess *ice, pj_ice_strans_op op, pj_status_t status)
Why the change here? This doesn't match the definition of the callback provided by pjproject:

res_rtp_asterisk.c:1685:2: error: initialization from incompatible pointer type [-Werror]
  .on_ice_complete = ast_rtp_on_ice_complete,


Line 1619:                 ast_log(LOG_WARNING,"ICE %s failed: %s\n", opname, errmsg);
opname is not defined and thus this won't compile:

res_rtp_asterisk.c:1619:99: error: ‘opname’ undeclared (first use in this function)
                 ast_log(LOG_WARNING,"ICE %s failed: %s\n", opname, errmsg);


-- 
To view, visit https://gerrit.asterisk.org/678
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4a62a9a0b63cf7282f86b25e16b04151823b14f
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 11.18
Gerrit-Owner: Eugene Voityuk <eugene at thirdlane.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-HasComments: Yes