[Asterisk-code-review] pjsip: Add blonde transfer tests and connected line update c... (testsuite[master])

[Matt Jordan]

Matt Jordan has posted comments on this change.

Change subject: pjsip: Add blonde transfer tests and connected line update checks.
......................................................................


Patch Set 1: Code-Review-1

(5 comments)

https://gerrit.asterisk.org/#/c/655/1/tests/channels/pjsip/transfers/attended_transfer/nominal/callee_local/test-config.yaml
File tests/channels/pjsip/transfers/attended_transfer/nominal/callee_local/test-config.yaml:

Line 5: SIPp #1 (uac.xml)
While this description existed prior to your patch, I noticed this in the review for the new blonde transfer test, so it might as well be fixed here as well.

This scenario actually doesn't exist. Is this supposed to be uac-no-hangup?


Line 6:  SIPp #2 kicks off SIPp #3 which calls SIPp #4.
It'd be worth noting which ones here are SIPp #3 and SIPp #4.


https://gerrit.asterisk.org/#/c/655/1/tests/channels/pjsip/transfers/attended_transfer/nominal/callee_local_blonde/test-config.yaml
File tests/channels/pjsip/transfers/attended_transfer/nominal/callee_local_blonde/test-config.yaml:

Line 6: SIPp #2 kicks off SIPp #3 which calls SIPp #4.
I'd note here which scenarios are SIPp #3 and SIPp #4


Line 14: SIPp #2 and SIPp #3 are hung up.
Wouldn't SIPp #2 be hung up prior to this?


Line 47:   minversion: '12.0.0'
Since connected line updates weren't working before your patch, this test would fail prior to the next fix version. I'd update this to 13.5.0.


-- 
To view, visit https://gerrit.asterisk.org/655
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5aa4aee05ae4bbd3e6fc110e608459b4c102b725
Gerrit-PatchSet: 1
Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-Owner: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-HasComments: Yes