[Asterisk-code-review] bridge: When performing a blonde transfer update connected l... (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change.

Change subject: bridge: When performing a blonde transfer update connected line information.
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

https://gerrit.asterisk.org/#/c/641/1/main/bridge_channel.c
File main/bridge_channel.c:

Line 1768: 	 * line information is already it (despite the channel not being told).
already it --> already there


Line 1771: 	ast_party_connected_line_init(ast_channel_connected_indicated(chan_target));
Memory leak.  ast_party_connected_line_init() assumes garbage is in the struct to initialize.  You need to use ast_party_connected_line_free().  Then you *might* need to call ast_party_connected_line_init() or do something else to guarantee that the connected line will always be seen as needing an update.


-- 
To view, visit https://gerrit.asterisk.org/641
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb8798184a1dab3ecd35299faecc420034adbf20
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes