[Asterisk-code-review] DNS: Fix some corner cases. (asterisk[master])

Richard Mudgett asteriskteam at digium.com
Wed Jun 10 18:19:40 CDT 2015


Richard Mudgett has posted comments on this change.

Change subject: DNS: Fix some corner cases.
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/#/c/626/1/main/dns_query_set.c
File main/dns_query_set.c:

Line 196: 		dns_query_set_callback(query->query);
        : 	}
        : 	if (!idx) {
        : 		/*
        : 		 * There were no queries in the set;
        : 		 * therefore all queries are "completed".
        : 		 * Invoke the final callback.
        : 		 */
        : 		query_set->callback(query_set);
        : 		ao2_cleanup(query_set->user_data);
        : 		query_set->user_data = NULL;
        : 	}
        : 	ao2_ref(query_set, -1);
> This is not a problem.  The use of the ast_cond_t is correctly coded in com
Done


-- 
To view, visit https://gerrit.asterisk.org/626
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie8be8347d0992e93946d72b6e7b1299727b038f2
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes



More information about the asterisk-code-review mailing list