[Asterisk-code-review] Fix listing of skipped tests. (testsuite[master])

Matt Jordan asteriskteam at digium.com
Fri Jun 5 18:03:45 CDT 2015 

Matt Jordan has submitted this change and it was merged.

Change subject: Fix listing of skipped tests.
......................................................................


Fix listing of skipped tests.

The testsuite supports identifying skipped tests in test-config.yaml.
This change uncomments tests from all tests.yaml files, instead using
the skip property of testinfo in test-config.yaml. The test listing
provided by `runtests.py -l` is also fixed to identify tests that are
skipped.

Change-Id: I96d9e96902116f7263c117fcdf201271b7926ae7
---
M runtests.py
M tests/apps/queues/macro_gosub_test/test-config.yaml
M tests/apps/queues/ringinuse_and_pause/test-config.yaml
M tests/apps/queues/tests.yaml
M tests/apps/queues/wrapup_time/test-config.yaml
M tests/cdr/app_queue/test-config.yaml
M tests/cdr/tests.yaml
M tests/channels/SIP/handle_response_refer/test-config.yaml
M tests/channels/SIP/tests.yaml
M tests/fastagi/tests.yaml
M tests/fastagi/wait-for-digit/test-config.yaml
M tests/manager/response-time/test-config.yaml
M tests/manager/tests.yaml
M tests/pbx/call-files2/test-config.yaml
M tests/pbx/merge_contexts/test-config.yaml
M tests/pbx/tests.yaml
16 files changed, 20 insertions(+), 19 deletions(-)

Approvals:
  Matt Jordan: Looks good to me, approved; Verified
  Joshua Colp: Looks good to me, but someone else must approve



diff --git a/runtests.py b/runtests.py
index 5bfaff6..0fe14f5 100755
--- a/runtests.py
+++ b/runtests.py
@@ -419,6 +419,8 @@
         for t in self.tests:
             print "%.3d) %s" % (i, t.test_config.test_name)
             print "      --> Summary: %s" % t.test_config.summary
+            if t.test_config.skip is not None:
+                print  "      --> Skip: %s" % t.test_config.skip
             print ("      --> Minimum Version: %s (%s)" %
                    (", ".join([str(v) for v in t.test_config.minversion]),
                     t.test_config.minversion_check))
diff --git a/tests/apps/queues/macro_gosub_test/test-config.yaml b/tests/apps/queues/macro_gosub_test/test-config.yaml
index 8425fde..f1d4530 100644
--- a/tests/apps/queues/macro_gosub_test/test-config.yaml
+++ b/tests/apps/queues/macro_gosub_test/test-config.yaml
@@ -1,5 +1,6 @@
 testinfo:
     summary:     'Test Macro and Gosub execution upon answer of Queue calls'
+    skip: 'Skip while failures are debugged'
     description: |
         'This test runs two calls through a queue. The queue is configured to run
         a particular macro and gosub when a member answers. For the first call, we
diff --git a/tests/apps/queues/ringinuse_and_pause/test-config.yaml b/tests/apps/queues/ringinuse_and_pause/test-config.yaml
index 07d2918..60837ae 100644
--- a/tests/apps/queues/ringinuse_and_pause/test-config.yaml
+++ b/tests/apps/queues/ringinuse_and_pause/test-config.yaml
@@ -1,5 +1,6 @@
 testinfo:
     summary:     'Test ringinuse and autopause'
+    skip: 'Skip while failures are debugged'
     description: |
         "This test accomplishes several tasks. First, it ensures that queue
         members in queues with ringinuse=no are not called. Second, it ensures
diff --git a/tests/apps/queues/tests.yaml b/tests/apps/queues/tests.yaml
index 1e8a8b3..d46a058 100644
--- a/tests/apps/queues/tests.yaml
+++ b/tests/apps/queues/tests.yaml
@@ -9,9 +9,6 @@
     - test: 'queue_no_answer'
     - test: 'queue_one_paused_no_answer'
     - test: 'queue_penalty_outside_range'
-    # Temporarily disabled while failures are debugged
-    #- test: 'macro_gosub_test'
-    # Temporarily disabled while failures are debugged
-    #- test: 'ringinuse_and_pause'
-    # Temporarily disabled while failures are debugged
-    #- test: 'wrapup_time'
+    - test: 'macro_gosub_test'
+    - test: 'ringinuse_and_pause'
+    - test: 'wrapup_time'
diff --git a/tests/apps/queues/wrapup_time/test-config.yaml b/tests/apps/queues/wrapup_time/test-config.yaml
index 39ee484..f48908e 100644
--- a/tests/apps/queues/wrapup_time/test-config.yaml
+++ b/tests/apps/queues/wrapup_time/test-config.yaml
@@ -1,5 +1,6 @@
 testinfo:
     summary:     'Test wrapuptime for queues'
+    skip: 'Skip while failures are debugged'
     description: |
         'This test runs two instances of Asterisk. One has shared_lastcall set in queues.conf
         and the other does not. Each instance of Asterisk contains two queues with the same two
diff --git a/tests/cdr/app_queue/test-config.yaml b/tests/cdr/app_queue/test-config.yaml
index 587e418..372b9c8 100644
--- a/tests/cdr/app_queue/test-config.yaml
+++ b/tests/cdr/app_queue/test-config.yaml
@@ -1,5 +1,6 @@
 testinfo:
     summary: 'Test for proper CDR dispositions for queue calls.'
+    skip: 'Skip while failures are debugged'
     description: |
         "This test verifies that the CDRs generated for calls involving
         app_queue have the proper dispositions."
diff --git a/tests/cdr/tests.yaml b/tests/cdr/tests.yaml
index 6d602a1..10ac044 100644
--- a/tests/cdr/tests.yaml
+++ b/tests/cdr/tests.yaml
@@ -7,8 +7,7 @@
     - test: 'cdr_bridge_multi'
     - test: 'console_dial_sip_transfer'
     - test: 'cdr_unanswered_yes'
-    # Temporarily disabled while failures are debugged
-    #- test: 'app_queue'
+    - test: 'app_queue'
     - test: 'originate-cdr-disposition'
     - test: 'app_dial_G_flag'
     - test: 'batch_cdrs'
diff --git a/tests/channels/SIP/handle_response_refer/test-config.yaml b/tests/channels/SIP/handle_response_refer/test-config.yaml
index 713b4e7..dd06577 100644
--- a/tests/channels/SIP/handle_response_refer/test-config.yaml
+++ b/tests/channels/SIP/handle_response_refer/test-config.yaml
@@ -1,5 +1,6 @@
 testinfo:
     summary: 'Test that asterisk properly handles responses to REFER requests'
+    skip: 'Skip while failures are debugged'
     description: |
         "This test verifies that asterisk behaves properly in the presence of
         various responses to REFER requests."
diff --git a/tests/channels/SIP/tests.yaml b/tests/channels/SIP/tests.yaml
index 9524a68..3f28351 100644
--- a/tests/channels/SIP/tests.yaml
+++ b/tests/channels/SIP/tests.yaml
@@ -1,7 +1,6 @@
 # Enter tests here in the order they should be considered for execution:
 tests:
-    # Temporarily disabled until random failures are debugged.
-    #- test: 'handle_response_refer'
+    - test: 'handle_response_refer'
     - test: 'acl_call'
     - test: 'options'
     - test: 'refer_replaces_to_self'
diff --git a/tests/fastagi/tests.yaml b/tests/fastagi/tests.yaml
index 6d51a42..2a34d17 100644
--- a/tests/fastagi/tests.yaml
+++ b/tests/fastagi/tests.yaml
@@ -16,5 +16,4 @@
     - test: 'say-digits'
     - test: 'say-number'
     - test: 'say-phonetic'
-    # Requires patch to StarPy.
-    #- test: 'wait-for-digit'
+    - test: 'wait-for-digit'
diff --git a/tests/fastagi/wait-for-digit/test-config.yaml b/tests/fastagi/wait-for-digit/test-config.yaml
index 84c420a..1269c5b 100644
--- a/tests/fastagi/wait-for-digit/test-config.yaml
+++ b/tests/fastagi/wait-for-digit/test-config.yaml
@@ -1,5 +1,6 @@
 testinfo:
     summary:     'Test AGI WAIT FOR DIGIT command using FastAGI.'
+    skip: 'Requires patch to StarPy'
     description: |
         'Test AGI WAIT FOR DIGIT command using FastAGI.'
 
diff --git a/tests/manager/response-time/test-config.yaml b/tests/manager/response-time/test-config.yaml
index f43e687..8a7d76f 100644
--- a/tests/manager/response-time/test-config.yaml
+++ b/tests/manager/response-time/test-config.yaml
@@ -1,5 +1,6 @@
 testinfo:
     summary:     'Test the expected response time for manager actions.'
+    skip: 'Skip while failures are debugged'
     description: |
         "This test ensures that the manager responds within a reasonable
         ammount of time for actions."
diff --git a/tests/manager/tests.yaml b/tests/manager/tests.yaml
index 7ab7265..e929fd7 100644
--- a/tests/manager/tests.yaml
+++ b/tests/manager/tests.yaml
@@ -20,6 +20,5 @@
     - test: 'status_all_vars'
     - test: 'userevent'
     - test: 'connected_line'
-    # Temporarily disabled while failures are debugged
-    #- test: 'response-time'
+    - test: 'response-time'
     - dir:  'redirect'
diff --git a/tests/pbx/call-files2/test-config.yaml b/tests/pbx/call-files2/test-config.yaml
index 09f5492..e8c7458 100644
--- a/tests/pbx/call-files2/test-config.yaml
+++ b/tests/pbx/call-files2/test-config.yaml
@@ -1,5 +1,6 @@
 testinfo:
     summary:     'Test Call Spools'
+    skip: 'Skip while failures are debugged'
     description: |
         'This test verifies that calls queued via the spooler do not cause warning messages about a file not existing.'
 
diff --git a/tests/pbx/merge_contexts/test-config.yaml b/tests/pbx/merge_contexts/test-config.yaml
index 2d43024..2d17deb 100644
--- a/tests/pbx/merge_contexts/test-config.yaml
+++ b/tests/pbx/merge_contexts/test-config.yaml
@@ -1,8 +1,8 @@
 testinfo:
     summary: 'Test mixing pbx_ael, pbx_config, and pbx_lua extensions in the same context.'
+    skip: 'Skip while failures are debugged'
     description: |
         This test verifies pbx_lua, pbx_ael, and pbx_config can be used in the same context.
-
     issues:
         - jira : ASTERISK-18230
 
diff --git a/tests/pbx/tests.yaml b/tests/pbx/tests.yaml
index 2299dd3..cb81af9 100644
--- a/tests/pbx/tests.yaml
+++ b/tests/pbx/tests.yaml
@@ -15,7 +15,5 @@
     - test: 'pbx_lua_goto'
     - test: 'pbx_lua_background'
     - test: 'manager_extensions'
-    # this test currently doesn't work due to a bug (ASTERISK-18230)
-    #- test: 'merge_contexts'
-    # Temporarily disabled while failures are debugged
-    #- test: 'call-files2'
+    - test: 'merge_contexts'
+    - test: 'call-files2'

-- 
To view, visit https://gerrit.asterisk.org/592
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I96d9e96902116f7263c117fcdf201271b7926ae7
Gerrit-PatchSet: 1
Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>

More information about the asterisk-code-review mailing list