[Asterisk-code-review] pjsip: Replace usage of localhost with 127.0.0.1 (testsuite[master])
Mark Michelson
asteriskteam at digium.com
Fri Jun 5 11:05:38 CDT 2015
Mark Michelson has submitted this change and it was merged.
Change subject: pjsip: Replace usage of localhost with 127.0.0.1
......................................................................
pjsip: Replace usage of localhost with 127.0.0.1
The upgrade to pjproject 2.4 on the Bamboo agents caused these to
start failing as no valid resolver is available. Since these tests
aren't really testing the resolver they don't need to be using
localhost.
A separate task for creation of a fallback system level resolver
has been created for fixing the resolver side of things.
Change-Id: I0c24ab8bec33823bfec4f5f0e567dc920605542f
---
M tests/channels/pjsip/dtmf_incompatible/configs/ast1/pjsip.conf
M tests/channels/pjsip/headers/configs/ast1/pjsip.conf
M tests/channels/pjsip/info_dtmf/configs/ast1/pjsip.conf
M tests/channels/pjsip/registration/inbound/nominal/path/sipp/registrar.xml
M tests/channels/pjsip/registration/inbound/nominal/path/sipp/ua1_invite_recv.xml
M tests/channels/pjsip/registration/inbound/nominal/path/sipp/ua1_register.xml
M tests/channels/pjsip/set_var/configs/ast1/pjsip.conf
M tests/channels/pjsip/video_calls/fast_picture_update/configs/ast1/pjsip.conf
8 files changed, 18 insertions(+), 18 deletions(-)
Approvals:
Mark Michelson: Looks good to me, approved; Verified
Richard Mudgett: Looks good to me, but someone else must approve
Corey Farrell: Looks good to me, but someone else must approve
diff --git a/tests/channels/pjsip/dtmf_incompatible/configs/ast1/pjsip.conf b/tests/channels/pjsip/dtmf_incompatible/configs/ast1/pjsip.conf
index d0a8a91..d1825f0 100644
--- a/tests/channels/pjsip/dtmf_incompatible/configs/ast1/pjsip.conf
+++ b/tests/channels/pjsip/dtmf_incompatible/configs/ast1/pjsip.conf
@@ -20,7 +20,7 @@
;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
[alice](aor_t)
-contact=sip:alice at localhost:5061
+contact=sip:alice at 127.0.0.1:5061
[alice](endpoint_t)
aors=alice
@@ -31,7 +31,7 @@
;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
[bob](aor_t)
-contact=sip:bob at localhost:5062
+contact=sip:bob at 127.0.0.1:5062
[bob](endpoint_t)
aors=bob
diff --git a/tests/channels/pjsip/headers/configs/ast1/pjsip.conf b/tests/channels/pjsip/headers/configs/ast1/pjsip.conf
index bb5a39e..a246036 100644
--- a/tests/channels/pjsip/headers/configs/ast1/pjsip.conf
+++ b/tests/channels/pjsip/headers/configs/ast1/pjsip.conf
@@ -21,7 +21,7 @@
aors=inbound
[inbound](aor_t)
-contact=sip:inbound at localhost:5061
+contact=sip:inbound at 127.0.0.1:5061
;; outbound
@@ -29,7 +29,7 @@
aors=outbound
[outbound](aor_t)
-contact=sip:outbound at localhost:5062
+contact=sip:outbound at 127.0.0.1:5062
;; outbound-two
@@ -37,4 +37,4 @@
aors=outbound-recv
[outbound-recv](aor_t)
-contact=sip:outbound-recv at localhost:5063
+contact=sip:outbound-recv at 127.0.0.1:5063
diff --git a/tests/channels/pjsip/info_dtmf/configs/ast1/pjsip.conf b/tests/channels/pjsip/info_dtmf/configs/ast1/pjsip.conf
index f3d3472..6a8769c 100644
--- a/tests/channels/pjsip/info_dtmf/configs/ast1/pjsip.conf
+++ b/tests/channels/pjsip/info_dtmf/configs/ast1/pjsip.conf
@@ -22,7 +22,7 @@
aors=test
[test](aor_t)
-contact=sip:test at localhost:5061
+contact=sip:test at 127.0.0.1:5061
;; test2
@@ -30,4 +30,4 @@
aors=test2
[test2](aor_t)
-contact=sip:test2 at localhost:5062
+contact=sip:test2 at 127.0.0.1:5062
diff --git a/tests/channels/pjsip/registration/inbound/nominal/path/sipp/registrar.xml b/tests/channels/pjsip/registration/inbound/nominal/path/sipp/registrar.xml
index d065f44..04378bf 100644
--- a/tests/channels/pjsip/registration/inbound/nominal/path/sipp/registrar.xml
+++ b/tests/channels/pjsip/registration/inbound/nominal/path/sipp/registrar.xml
@@ -21,7 +21,7 @@
[last_To:];tag=[pid]SIPpTag01[call_number]
[last_Call-ID:]
[last_CSeq:]
- Route: <sip:localhost:5062;lr>,<sip:P1.EXAMPLEVISITED.COM;lr>
+ Route: <sip:127.0.0.1:5062;lr>,<sip:P1.EXAMPLEVISITED.COM;lr>
Contact: <sip:[local_ip]:[local_port];transport=[transport]>
Content-Type: application/sdp
Content-Length: [len]
diff --git a/tests/channels/pjsip/registration/inbound/nominal/path/sipp/ua1_invite_recv.xml b/tests/channels/pjsip/registration/inbound/nominal/path/sipp/ua1_invite_recv.xml
index 3e82905..38d03b0 100644
--- a/tests/channels/pjsip/registration/inbound/nominal/path/sipp/ua1_invite_recv.xml
+++ b/tests/channels/pjsip/registration/inbound/nominal/path/sipp/ua1_invite_recv.xml
@@ -29,7 +29,7 @@
search_in="hdr"
check_it="true"
assign_to="remote"/>
- <ereg regexp=".*<sip:localhost:5062;lr>.*"
+ <ereg regexp=".*<sip:127.0.0.1:5062;lr>.*"
header="Route:"
search_in="hdr"
check_it="true"
@@ -54,7 +54,7 @@
[last_To:];tag=[pid]SIPpTag01[call_number]
[last_Call-ID:]
[last_CSeq:]
- Route: <sip:localhost:5062;lr>,<sip:P1.EXAMPLEVISITED.COM;lr>
+ Route: <sip:127.0.0.1:5062;lr>,<sip:P1.EXAMPLEVISITED.COM;lr>
Contact: <sip:[local_ip]:[local_port];transport=[transport]>
Content-Length: 0
@@ -70,7 +70,7 @@
[last_To:];tag=[pid]SIPpTag01[call_number]
[last_Call-ID:]
[last_CSeq:]
- Route: <sip:localhost:5062;lr>,<sip:P1.EXAMPLEVISITED.COM;lr>
+ Route: <sip:127.0.0.1:5062;lr>,<sip:P1.EXAMPLEVISITED.COM;lr>
Contact: <sip:[local_ip]:[local_port];transport=[transport]>
Content-Type: application/sdp
Content-Length: [len]
@@ -101,7 +101,7 @@
[last_Call-ID:]
CSeq: [cseq] BYE
Contact: ua1 <sip:ua1@[local_ip]:[local_port]>
- Route: <sip:localhost:5062;lr>,<sip:P1.EXAMPLEVISITED.COM;lr>
+ Route: <sip:127.0.0.1:5062;lr>,<sip:P1.EXAMPLEVISITED.COM;lr>
Max-Forwards: 70
Subject: Path Test
Content-Length: 0
diff --git a/tests/channels/pjsip/registration/inbound/nominal/path/sipp/ua1_register.xml b/tests/channels/pjsip/registration/inbound/nominal/path/sipp/ua1_register.xml
index 03676de..6221e6b 100644
--- a/tests/channels/pjsip/registration/inbound/nominal/path/sipp/ua1_register.xml
+++ b/tests/channels/pjsip/registration/inbound/nominal/path/sipp/ua1_register.xml
@@ -15,7 +15,7 @@
Subject: Path Test
Expires: 3600
Supported: path
- Path: <sip:localhost:5062;lr>,<sip:P1.EXAMPLEVISITED.COM;lr>
+ Path: <sip:127.0.0.1:5062;lr>,<sip:P1.EXAMPLEVISITED.COM;lr>
Content-Length: 0
]]>
@@ -23,7 +23,7 @@
<recv response="200" rtd="true">
<action>
- <ereg regexp=".*<sip:localhost:5062;lr>,<sip:P1.EXAMPLEVISITED.COM;lr>.*"
+ <ereg regexp=".*<sip:127.0.0.1:5062;lr>,<sip:P1.EXAMPLEVISITED.COM;lr>.*"
search_in="hdr" header="Path:" check_it="true" assign_to="1"/>
<ereg regexp=".*path.*"
search_in="hdr" header="Supported:" check_it="true" assign_to="2"/>
diff --git a/tests/channels/pjsip/set_var/configs/ast1/pjsip.conf b/tests/channels/pjsip/set_var/configs/ast1/pjsip.conf
index e89e762..c68bb91 100644
--- a/tests/channels/pjsip/set_var/configs/ast1/pjsip.conf
+++ b/tests/channels/pjsip/set_var/configs/ast1/pjsip.conf
@@ -22,7 +22,7 @@
;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
[alice](aor_t)
-contact=sip:alice at localhost:5061
+contact=sip:alice at 127.0.0.1:5061
[alice](endpoint_t)
aors=alice
@@ -35,7 +35,7 @@
;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
[bob](aor_t)
-contact=sip:bob at localhost:5062
+contact=sip:bob at 127.0.0.1:5062
[bob](endpoint_t)
aors=bob
diff --git a/tests/channels/pjsip/video_calls/fast_picture_update/configs/ast1/pjsip.conf b/tests/channels/pjsip/video_calls/fast_picture_update/configs/ast1/pjsip.conf
index 13354cf..e6fb2b8 100644
--- a/tests/channels/pjsip/video_calls/fast_picture_update/configs/ast1/pjsip.conf
+++ b/tests/channels/pjsip/video_calls/fast_picture_update/configs/ast1/pjsip.conf
@@ -21,7 +21,7 @@
aors=alice
[alice](aor_t)
-contact=sip:alice at localhost:5061
+contact=sip:alice at 127.0.0.1:5061
;; bob
@@ -29,4 +29,4 @@
aors=bob
[bob](aor_t)
-contact=sip:bob at localhost:5062
+contact=sip:bob at 127.0.0.1:5062
--
To view, visit https://gerrit.asterisk.org/591
To unsubscribe, visit https://gerrit.asterisk.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0c24ab8bec33823bfec4f5f0e567dc920605542f
Gerrit-PatchSet: 1
Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-Owner: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
More information about the asterisk-code-review
mailing list