[Asterisk-code-review] sorcery: Add SorceryMemoryCache AMI action tests. (testsuite[master])

Samuel Galarneau asteriskteam at digium.com
Thu Jun 4 09:08:36 CDT 2015


Samuel Galarneau has posted comments on this change.

Change subject: sorcery: Add SorceryMemoryCache AMI action tests.
......................................................................


Patch Set 2:

I don't have a problem with this going in as is but looking at memory_cache_expire.py vs memory_cache_expire_object.py and memory_cache_stale.py vs memory_cache_stale_object.py it looks like they are very similar. It might be worth it to look into combining them and making the module more configurable.

-- 
To view, visit https://gerrit.asterisk.org/544
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8fc051a92f52ae4e8e064333138157f28fabfa5f
Gerrit-PatchSet: 2
Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-Owner: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Samuel Galarneau <sgalarneau at digium.com>
Gerrit-HasComments: No



More information about the asterisk-code-review mailing list