[Asterisk-code-review] res pjsip session: Fix in-dialog authentication. (asterisk[certified/13.1])

[Richard Mudgett]

Richard Mudgett has posted comments on this change.

Change subject: res_pjsip_session: Fix in-dialog authentication.
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/#/c/559/1/res/res_pjsip_session.c
File res/res_pjsip_session.c:

Line 2509: 	ast_sip_unregister_service(&outbound_invite_auth_module);
         : 	ast_sip_unregister_service(&session_reinvite_module);
         : 	ast_sip_unregister_service(&session_module);
         : 	ast_sorcery_delete(ast_sip_get_sorcery(), nat_hook);
         : 	ao2_cleanup(nat_hook);
         : 	ao2_cleanup(sdp_handlers);
> The changes which allowed stuff to be unloaded were never merged into here.
I only added them because the patch was adding another thing to the cleanup list.  If the unload patch is ever merged in then the new cleanup line wouldn't be there.  Though merging the unloading patch into this branch is unlikely.

Would you prefer that I not touch this routine as the module cannot be unloaded?


-- 
To view, visit https://gerrit.asterisk.org/559
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I12bdd7ddccc819b4ce4b091e826d1e26334601b0
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: certified/13.1
Gerrit-Owner: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes