[Asterisk-code-review] ARI: Rotate log channels. (asterisk[13])

[Kevin Harwell]

Kevin Harwell has posted comments on this change.

Change subject: ARI: Rotate log channels.
......................................................................


Patch Set 2: Code-Review-1

(2 comments)

https://gerrit.asterisk.org/#/c/988/2/main/logger.c
File main/logger.c:

Line 939: 	struct ast_str *filename = ast_str_create(64);
filename is leaked. It needs to be freed.


Line 951: 			/*** DOCUMENTATION
        : 				<managerEventInstance>
        : 					<synopsis>Raised when a logging channel is re-enabled after a reload operation.</synopsis>
        : 					<syntax>
        : 						<parameter name="Channel">
        : 							<para>The name of the logging channel.</para>
        : 						</parameter>
        : 					</syntax>
        : 				</managerEventInstance>
        : 		
Does having two instances of the documentation for the same event cause any problems? I'm thinking you can just delete this here since it is declared somewhere else?


-- 
To view, visit https://gerrit.asterisk.org/988
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaefa21cbbc1b29effb33004ee3d89c977e76ab01
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-HasComments: Yes