[Asterisk-code-review] ARI: Retrieve existing log channels (asterisk[13])

Mark Michelson asteriskteam at digium.com
Wed Jul 29 15:06:07 CDT 2015


Mark Michelson has posted comments on this change.

Change subject: ARI: Retrieve existing log channels
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.asterisk.org/#/c/986/2/res/ari/ari_model_validators.h
File res/ari/ari_model_validators.h:

Line 243: ari_validator ast_ari_validate_log_channel_fn(void);
> Yeah that does look like a problem. We may need to file an issue on that.
Don't file an issue. Near the top of ari_model_validators.h, there is

typedef int (*ari_validator)(struct ast_json *json);

ari_validator is a function pointer type that takes in json and returns an int. There's no issue here.


-- 
To view, visit https://gerrit.asterisk.org/986
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7bb08b93e3b938c991f3f56cc5d188654768a808
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Scott Emidy <jemidy at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Scott Emidy <jemidy at digium.com>
Gerrit-HasComments: Yes



More information about the asterisk-code-review mailing list